Subject: [PATCH v3 0/2] oidmap: migrate cleanup to oidmap_clear_with_free()

From: Seyi Kuforiji <[email-masked]>
Date: Thu, 5 Mar 2026 11:05:24 +0100

Hi,

This series replaces oidmap_clear(map, 1) with
oidmap_clear_with_free() and introduces explicit free callbacks
at the remaining call sites.

The old boolean-based API implicitly assumed plain free(),
which obscures ownership semantics and does not work well
when oidmap_entry is embedded inside larger structures.
The callback-based API makes cleanup explicit and type-safe,
and avoids relying on hidden assumptions about allocation.

This is used in subsequent commits to adequately cleanup all
usage site.

Changes in v3:
 - rename funtion to meet guidlines
 - drop [PATCH 3/5]

Thanks
Seyi

Seyi Kufoiji (2):
  oidmap: make entry cleanup explicit in oidmap_clear
  builtin/rev-list: migrate missing_objects cleanup to
    oidmap_clear_with_free()

 builtin/rev-list.c      | 15 ++++++++++++---
 oidmap.c                | 23 ++++++++++++++++++++---
 oidmap.h                | 15 +++++++++++++++
 t/unit-tests/u-oidmap.c | 41 +++++++++++++++++++++++++++++++++++++++++
 4 files changed, 88 insertions(+), 6 deletions(-)

Range-diff against v2:
1:  1d544ef7d2 = 1:  a050491441 oidmap: make entry cleanup explicit in oidmap_clear
2:  f2c3a699bd ! 2:  b592d765e3 builtin/rev-list: migrate missing_objects cleanup to oidmap_clear_with_free()
    @@ builtin/rev-list.c: static int arg_print_omitted; /* print objects omitted by fi
      	unsigned type;
      };
     +
    -+static void free_missing_objects_entry(void *e)
    ++static void missing_objects_map_entry_free(void *e)
     +{
     +	struct missing_objects_map_entry *entry =
     +		container_of(e, struct missing_objects_map_entry, entry);
    @@ builtin/rev-list.c: int cmd_rev_list(int argc,
      		}
      
     -		oidmap_clear(&missing_objects, true);
    -+		oidmap_clear_with_free(&missing_objects, free_missing_objects_entry);
    ++		oidmap_clear_with_free(&missing_objects, missing_objects_map_entry_free);
      	}
      
      	stop_progress(&progress);
3:  a4e426bcca < -:  ---------- list-objects-filter: use oidmap_clear_with_free() for cleanup
4:  4116e5491d < -:  ---------- odb: use oidmap_clear_with_free() to release replace_map entries
5:  ad1f776a19 < -:  ---------- sequencer: use oidmap_clear_with_free() for string_entry cleanup
-- 
2.43.0