From: Jeff King <peff@peff•net>
To: Tian Yuchen <cat@malon•dev>
Cc: git@vger•kernel.org, Scott Baker <scott@perturb•org>
Subject: Re: [PATCH 8/8] diff-highlight: fetch all config with one process
Date: Mon, 23 Mar 2026 01:57:32 -0400 [thread overview]
Message-ID: <20260323055732.GB9976@coredump.intra.peff.net> (raw)
In-Reply-To: <9818e3ec-838a-4eef-8436-a395f2970d42@malon.dev>
On Mon, Mar 23, 2026 at 01:39:44PM +0800, Tian Yuchen wrote:
> > I don't get any warning on perl 5.40.1. Are you seeing one on a
> > different version?
>
> It's mainly because I saw that you changed the required version earlier：
>
> -require v5.26;
> +require v5.008;
>
> I clearly remember that in older versions of Perl, the length function
> behaved differently than it does now.
Heh, it figures that dropping back the version requirement would bite me
immediately. ;)
> In 5.8.8 the output is:
>
> Use of uninitialized value in length at test.pl line 5.
Yeah, looks like it changed in 5.12:
https://www.effectiveperlprogramming.com/2010/09/in-perl-v5-12-lengthundef-returns-undef/
I had actually written it using exists() originally, but then dropped it
to keep the diff smaller. Which is a silly reason. I've switched it to
use:
return defined($s) ? $s : $default;
which I think captures the intent pretty clearly. You could also use
"$s || $default", but I try to avoid that because of surprise-false
values. In modern perl you could just use "//", but that wasn't added
until v5.10.
Thanks for pointing it out!
-Peff
next prev parent reply other threads:[~2026-03-23 5:57 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-20 0:41 [PATCH 0/8] some diff-highlight tweaks Jeff King
2026-03-20 0:42 ` [PATCH 1/8] diff-highlight: mention build instructions Jeff King
2026-03-20 0:42 ` [PATCH 2/8] diff-highlight: drop perl version dependency back to 5.8 Jeff King
2026-03-20 0:43 ` [PATCH 3/8] diff-highlight: check diff-highlight exit status in tests Jeff King
2026-03-20 0:43 ` [PATCH 4/8] t: add matching negative attributes to test_decode_color Jeff King
2026-03-20 0:44 ` [PATCH 5/8] diff-highlight: use test_decode_color in tests Jeff King
2026-03-22 17:24 ` Tian Yuchen
2026-03-22 20:47 ` Jeff King
2026-03-23 5:48 ` Tian Yuchen
2026-03-23 5:53 ` Jeff King
2026-03-20 0:45 ` [PATCH 6/8] diff-highlight: test color config Jeff King
2026-03-20 0:47 ` [PATCH 7/8] diff-highlight: allow module callers to pass in " Jeff King
2026-03-20 0:48 ` [PATCH 8/8] diff-highlight: fetch all config with one process Jeff King
2026-03-22 17:18 ` Tian Yuchen
2026-03-22 20:45 ` Jeff King
2026-03-23 5:39 ` Tian Yuchen
2026-03-23 5:57 ` Jeff King [this message]
2026-03-23 6:01 ` [PATCH v2 0/8] some diff-highlight tweaks Jeff King
2026-03-23 6:01 ` [PATCH v2 1/8] diff-highlight: mention build instructions Jeff King
2026-03-23 6:02 ` [PATCH v2 2/8] diff-highlight: drop perl version dependency back to 5.8 Jeff King
2026-03-23 6:02 ` [PATCH v2 3/8] diff-highlight: check diff-highlight exit status in tests Jeff King
2026-03-23 6:02 ` [PATCH v2 4/8] t: add matching negative attributes to test_decode_color Jeff King
2026-03-23 6:02 ` [PATCH v2 5/8] diff-highlight: use test_decode_color in tests Jeff King
2026-03-23 6:02 ` [PATCH v2 6/8] diff-highlight: test color config Jeff King
2026-03-23 6:02 ` [PATCH v2 7/8] diff-highlight: allow module callers to pass in " Jeff King
2026-03-23 6:02 ` [PATCH v2 8/8] diff-highlight: fetch all config with one process Jeff King
2026-03-23 16:38 ` [PATCH v2 0/8] some diff-highlight tweaks Junio C Hamano
2026-03-24 6:50 ` Patrick Steinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260323055732.GB9976@coredump.intra.peff.net \
--to=peff@peff$(echo .)net \
--cc=cat@malon$(echo .)dev \
--cc=git@vger$(echo .)kernel.org \
--cc=scott@perturb$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox