From: Jeff King <peff@peff•net>
To: Wesley <wesleys@opperschaap•net>
Cc: git@vger•kernel.org, Junio C Hamano <gitster@pobox•com>,
Jiang Xin <zhiyou.jx@alibaba-inc•com>,
Derrick Stolee <stolee@gmail•com>, Patrick Steinhardt <ps@pks•im>
Subject: Re: [PATCH 1/3] connect: Rename name to command in connect_git()
Date: Fri, 27 Mar 2026 21:44:26 -0400 [thread overview]
Message-ID: <20260328014426.GA621762@coredump.intra.peff.net> (raw)
In-Reply-To: <3e9d8d71-9595-4151-8133-300b89b3b7f8@opperschaap.net>
On Fri, Mar 27, 2026 at 08:58:22PM -0400, Wesley wrote:
> > So probably "op" or "type" is a more accurate description. This
> > conceptually ought to be an enum, too, since it is selecting from a
> > limited set of operations we know about.
>
> That's a fair take on it, "name" is really a not the best name for this
> variable. I think "op" covers what you describe here best, it reflects also
> why I named it command. When you check what is sent via ssh, it looks like
> the command:
>
> ssh -o SendEnv=GIT_PROTOCOL git@gitlab•com git-upload-pack
> 'waterkip/git.git'
Right, but it's necessarily what is sent via ssh. E.g.:
$ GIT_TRACE=1 git ls-remote example.com:repo.git
[...]
trace: start_command: /usr/bin/ssh -o SendEnv=GIT_PROTOCOL example.com 'git-upload-pack '\''repo.git'\'''
$ GIT_TRACE=1 git ls-remote --upload-pack=foobar example.com:repo.git
[...]
trace: start_command: /usr/bin/ssh -o SendEnv=GIT_PROTOCOL example.com 'foobar '\''repo.git'\'''
That's why I think "command" is actively misleading, because between
"prog" and "command" it is not clear which one is going to be sent to
the remote.
-Peff
next prev parent reply other threads:[~2026-03-28 1:44 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-26 23:37 [PATCH 0/3] Add support for per-remote and per-namespace SSH options Wesley Schwengle
2026-03-26 23:37 ` [PATCH 1/3] connect: Rename name to command in connect_git() Wesley Schwengle
2026-03-27 21:33 ` Jeff King
2026-03-28 0:58 ` Wesley
2026-03-28 1:44 ` Jeff King [this message]
2026-03-28 2:01 ` Wesley
2026-03-26 23:37 ` [PATCH 2/3] connect: Add transport->remote->name to git_connect() Wesley Schwengle
2026-03-27 21:39 ` Jeff King
2026-03-26 23:37 ` [PATCH 3/3] connect: Add support for per-remote and per-namespace SSH options Wesley Schwengle
2026-03-27 21:45 ` Jeff King
2026-03-28 0:43 ` Wesley
2026-03-28 2:03 ` Jeff King
2026-03-28 2:25 ` Wesley
2026-03-27 7:51 ` [PATCH 0/3] " Johannes Sixt
2026-03-27 15:04 ` Wesley
2026-03-27 16:10 ` Junio C Hamano
2026-03-27 16:49 ` Wesley
2026-03-27 22:06 ` brian m. carlson
2026-03-28 1:02 ` Wesley
2026-03-28 7:46 ` Johannes Sixt
2026-03-28 14:59 ` Wesley
2026-03-29 14:33 ` Ben Knoble
2026-03-27 21:51 ` brian m. carlson
2026-03-27 22:25 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260328014426.GA621762@coredump.intra.peff.net \
--to=peff@peff$(echo .)net \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=ps@pks$(echo .)im \
--cc=stolee@gmail$(echo .)com \
--cc=wesleys@opperschaap$(echo .)net \
--cc=zhiyou.jx@alibaba-inc$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox