From: Tuomas Ahola <taahol@utu•fi>
To: Junio C Hamano <gitster@pobox•com>
Cc: <git@vger•kernel.org>, Jeff King <peff@peff•net>
Subject: Re: [PATCH v5 0/4] approxidate: tweak special date formats
Date: Thu, 21 May 2026 17:14:09 +0300 [thread overview]
Message-ID: <20260521141409.5vXT3%taahol@utu.fi> (raw)
In-Reply-To: <xmqqik8g28gw.fsf@gitster.g>
Junio C Hamano <gitster@pobox•com> wrote:
> Tuomas Ahola <taahol@utu•fi> writes:
>
> > -static void date_today(struct tm *tm, struct tm *now, int *num UNUSED)
> > +static void date_today(struct tm *tm, struct tm *now, int *num)
> > {
> > if (tm->tm_hour == now->tm_hour &&
> > tm->tm_min == now->tm_min &&
> > tm->tm_sec == now->tm_sec)
> > date_time(tm, 0);
> > + *num = 0;
> > tm->tm_mday = -1;
> > update_tm(tm, now, 0);
> > }
>
> Hmph, what is this change about? Does the lack of this clearing
> break some test?
>
As you can see, many other date_*() functions have that same assignment, too.
It looked a bit off, so I first left it out, but this revision does add a
corner case test[*] that would fail without it.
> In any case, will queue. It seems that we are getting to the point
> of diminishing returns and better off declaring victory soonish?
>
Yes, I agree. The patch series is effectively finished as I don't have any
further itches or ideas. And I think the series gets its work done quite well
actually.
> > +check_approxidate 'January 5th today pm' '2009-01-30 12:00:00'
[*] Namely, this one.
prev parent reply other threads:[~2026-05-21 14:14 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-18 18:01 [PATCH 0/2] approxidate: tweak special date formats Tuomas Ahola
2025-03-18 18:02 ` [PATCH 1/2] approxidate: make "specials" respect fixed day-of-month Tuomas Ahola
2025-04-04 8:19 ` Jeff King
2025-03-18 18:02 ` [PATCH 2/2] approxidate: overwrite tm_mday for `now` and `yesterday` Tuomas Ahola
2025-04-04 8:40 ` Jeff King
2026-05-12 14:54 ` [PATCH v2 0/3] approxidate: tweak special date formats Tuomas Ahola
2026-05-12 14:54 ` [PATCH v2 1/3] t0006: add support for approxidate test date adjustment Tuomas Ahola
2026-05-12 16:34 ` Junio C Hamano
2026-05-12 18:35 ` Jeff King
2026-05-12 14:54 ` [PATCH v2 2/3] approxidate: make "specials" respect fixed day-of-month Tuomas Ahola
2026-05-12 16:52 ` Junio C Hamano
2026-05-12 14:54 ` [PATCH v2 3/3] approxidate: use deferred mday adjustments for "specials" Tuomas Ahola
2026-05-14 11:55 ` [PATCH v3 0/4] approxidate: tweak special date formats Tuomas Ahola
2026-05-14 11:55 ` [PATCH v3 1/4] t0006: add support for approxidate test date adjustment Tuomas Ahola
2026-05-14 11:55 ` [PATCH v3 2/4] approxidate: alias "today" to "now" Tuomas Ahola
2026-05-14 15:36 ` Junio C Hamano
2026-05-14 21:07 ` Tuomas Ahola
2026-05-15 1:27 ` Junio C Hamano
2026-05-15 1:38 ` Junio C Hamano
2026-05-15 5:02 ` Tuomas Ahola
2026-05-14 11:55 ` [PATCH v3 3/4] approxidate: make "specials" respect fixed day-of-month Tuomas Ahola
2026-05-14 16:06 ` Junio C Hamano
2026-05-14 11:55 ` [PATCH v3 4/4] approxidate: use deferred mday adjustments for "specials" Tuomas Ahola
2026-05-16 15:15 ` [PATCH v4 0/4] approxidate: tweak special date formats Tuomas Ahola
2026-05-16 15:15 ` [PATCH v4 1/4] approxidate: make "today" wrap to midnight Tuomas Ahola
2026-05-16 15:15 ` [PATCH v4 2/4] t0006: add support for approxidate test date adjustment Tuomas Ahola
2026-05-16 15:15 ` [PATCH v4 3/4] approxidate: make "specials" respect fixed day-of-month Tuomas Ahola
2026-05-16 15:15 ` [PATCH v4 4/4] approxidate: use deferred mday adjustments for "specials" Tuomas Ahola
2026-05-18 2:40 ` [PATCH] fixup! " Tuomas Ahola
2026-05-21 10:54 ` [PATCH v5 0/4] approxidate: tweak special date formats Tuomas Ahola
2026-05-21 10:54 ` [PATCH v5 1/4] approxidate: make "today" wrap to midnight Tuomas Ahola
2026-05-21 10:54 ` [PATCH v5 2/4] t0006: add support for approxidate test date adjustment Tuomas Ahola
2026-05-21 10:54 ` [PATCH v5 3/4] approxidate: make "specials" respect fixed day-of-month Tuomas Ahola
2026-05-21 10:54 ` [PATCH v5 4/4] approxidate: use deferred mday adjustments for "specials" Tuomas Ahola
2026-05-21 13:33 ` [PATCH v5 0/4] approxidate: tweak special date formats Junio C Hamano
2026-05-21 14:14 ` Tuomas Ahola [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260521141409.5vXT3%taahol@utu.fi \
--to=taahol@utu$(echo .)fi \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=peff@peff$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox