From: Jeff King <peff@peff•net>
To: kristofferhaugsbakk@fastmail•com
Cc: Junio C Hamano <gitster@pobox•com>,
Kristoffer Haugsbakk <code@khaugsbakk•name>,
Patrick Steinhardt <ps@pks•im>,
git@vger•kernel.org
Subject: Re: [PATCH v2 0/2] commit: remove deprecated functions
Date: Fri, 29 May 2026 04:37:16 -0400 [thread overview]
Message-ID: <20260529083716.GE1106035@coredump.intra.peff.net> (raw)
In-Reply-To: <V2_CV_commit.h_remove_deprecated.732@msgid.xyz>
On Thu, May 28, 2026 at 09:00:09AM +0200, kristofferhaugsbakk@fastmail•com wrote:
> Topic summary: Remove deprecated comments that were slated for removal
> after Git 2.53.0.
This looks obviously correct to me, but the whole topic made me wonder:
was it worth retaining the old names and deprecating them, versus just
removing them back then?
Topics in flight would have needed an update then, but they did
eventually anyway. So it feels like the total amount of work done is
larger, compared to just fixing them as the topics were merged. Either
way the compiler tells us, and the adjustments themselves are small.
Not a huge deal either way, but just pondering for future such
situations.
-Peff
next prev parent reply other threads:[~2026-05-29 8:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-27 13:59 [PATCH 0/2] commit: remove deprecated functions kristofferhaugsbakk
2026-05-27 13:59 ` [PATCH 1/2] *: replace deprecated free_commit_list kristofferhaugsbakk
2026-05-28 5:24 ` Patrick Steinhardt
2026-05-28 6:49 ` Kristoffer Haugsbakk
2026-05-27 13:59 ` [PATCH 2/2] commit: remove deprecated functions kristofferhaugsbakk
2026-05-28 5:24 ` Patrick Steinhardt
2026-05-28 7:00 ` [PATCH v2 0/2] " kristofferhaugsbakk
2026-05-28 7:00 ` [PATCH v2 1/2] *: replace deprecated free_commit_list kristofferhaugsbakk
2026-05-28 7:00 ` [PATCH v2 2/2] commit: remove deprecated functions kristofferhaugsbakk
2026-05-29 8:37 ` Jeff King [this message]
2026-06-01 5:58 ` [PATCH v2 0/2] " Patrick Steinhardt
2026-06-01 7:14 ` Junio C Hamano
2026-06-02 6:23 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260529083716.GE1106035@coredump.intra.peff.net \
--to=peff@peff$(echo .)net \
--cc=code@khaugsbakk$(echo .)name \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=kristofferhaugsbakk@fastmail$(echo .)com \
--cc=ps@pks$(echo .)im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox