Subject: jh/p4-various-fixups (was: What's cooking in git.git (Mar 2022, #07; Wed, 30))

From: Ævar Arnfjörð Bjarmason <[email-masked]>
Date: Thu, 31 Mar 2022 11:41:36 +0200

On Wed, Mar 30 2022, Junio C Hamano wrote:

> Also, there are a couple of "git p4" patches, for which we seem to
> totally lack reviewers.  Help is appreciated, here, too.
> [...]
> * jh/p4-various-fixups (2022-02-10) 22 commits
>  - git-p4: sort imports
>  - git-p4: seperate multiple statements onto seperate lines
>  - git-p4: move inline comments to line above
>  - git-p4: only seperate code blocks by a single empty line
>  - git-p4: compare to singletons with "is" and "is not"
>  - git-p4: normalize indentation of lines in conditionals
>  - git-p4: ensure there is a single space around all operators
>  - git-p4: ensure every comment has a single #
>  - git-p4: remove spaces between dictionary keys and colons
>  - git-p4: remove redundant backslash-continuations inside brackets
>  - git-p4: remove extraneous spaces before function arguments
>  - git-p4: place a single space after every comma
>  - git-p4: removed brackets when assigning multiple return values
>  - git-p4: remove spaces around default arguments
>  - git-p4: remove padding from lists, tuples and function arguments
>  - git-p4: sort and de-duplcate pylint disable list
>  - git-p4: remove commented code
>  - git-p4: convert descriptive class and function comments into docstrings
>  - git-p4: improve consistency of docstring formatting
>  - git-p4: indent with 4-spaces
>  - git-p4: remove unneeded semicolons from statements
>  - git-p4: add blank lines between functions and class definitions
>
>  Various cleanups to "git p4".
>
>  Needs review.
>  source: <[email-masked]>

The tip here lacks a Signed-Off-By, but this otherwise looks good to
me.

I don't have a setup to actually test it, but aside from the import
re-shuffling these are all purely stylistic changes.