Subject: Re: [PATCH v4 11/16] bisect--helper: return only correct exit codes in `cmd_*()`

From: Ævar Arnfjörð Bjarmason <[email-masked]>
Date: Mon, 27 Jun 2022 22:09:28 +0200

On Mon, Jun 27 2022, Johannes Schindelin via GitGitGadget wrote:

> From: Johannes Schindelin <[email-masked]>
>
> Exit codes cannot be negative, but `error()` returns -1.

That's good, but...

> Let's just go with the common pattern and call `die()` in
> `cmd_bisect__helper()` when incorrect arguments were detected.

...the common and correct pattern on bad options is to return 129, not
128, which using use usage_msg_opt() instead of die() here would give
you for free. I think this should use that instead.