From: layer <layer@known•net>
To: Jeff King <peff@peff•net>
Cc: git@vger•kernel.org
Subject: Re: post-checkout hook not run on clone
Date: Mon, 02 Mar 2009 21:02:29 -0800 [thread overview]
Message-ID: <23978.1236056549@relay.known.net> (raw)
In-Reply-To: <20090303042848.GC18136@coredump.intra.peff.net>
Jeff King <peff@peff•net> wrote:
>> On Mon, Mar 02, 2009 at 02:43:37PM -0800, layer wrote:
>>
>> > I realize this might be a feature, but when I switch to the master
>> > branch with "git checkout master" it is, and I would think that a
>> > clone that gets the master branch would also does a sort of "checkout
>> > master" and would run the hook.
>>
>> Right. Hooks are not cloned with the repo.
The hook in question was in /usr/share/git-core/templates/hooks/, so
it would get setup on clone. That works fine. If I immediately
switch branches, the hook gets called. It's just the `post-clone'
(when I assume something like `checkout' is done), the hook doesn't
get called.
>> The general wisdom on the list is that it's a bad idea to run remote
>> code arbitrarily for security reasons...
I agree, but not in this specific situation. All the users of the
code are trusted, as is the author of the hooks.
next prev parent reply other threads:[~2009-03-03 5:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-02 22:43 post-checkout hook not run on clone layer
2009-03-03 4:28 ` Jeff King
2009-03-03 5:02 ` layer [this message]
2009-03-03 5:10 ` Jeff King
2009-03-03 5:37 ` [PATCH] clone: run post-checkout hook when checking out Jeff King
2009-03-03 6:45 ` Junio C Hamano
2009-03-03 6:55 ` Jay Soffian
2009-03-03 10:07 ` Nanako Shiraishi
2009-03-03 7:03 ` Jeff King
2009-03-04 5:01 ` layer
2009-03-03 5:04 ` post-checkout hook not run on clone Shawn O. Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23978.1236056549@relay.known.net \
--to=layer@known$(echo .)net \
--cc=git@vger$(echo .)kernel.org \
--cc=peff@peff$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox