From: "Kristoffer Haugsbakk" <kristofferhaugsbakk@fastmail•com>
To: "Josh Soref" <gitgitgadget@gmail•com>, git@vger•kernel.org
Cc: "Elijah Newren" <newren@gmail•com>
Subject: Re: [PATCH 1/3] t6429: update comment to mention correct tool
Date: Fri, 07 Nov 2025 15:36:26 +0100 [thread overview]
Message-ID: <2983385e-daeb-40c0-a8bc-fb8bd3b744a6@app.fastmail.com> (raw)
In-Reply-To: <950236f0f812197e260159a688fc6f6fa61046c7.1762192908.git.gitgitgadget@gmail.com>
On Mon, Nov 3, 2025, at 19:01, Elijah Newren via GitGitGadget wrote:
> From: Elijah Newren <newren@gmail•com>
>
> A comment at the top of t6429 mentions why the test doesn't exercise git
> rebase or git cherry-pick. However, it claims that it uses `test-tool
> fast-rebase`. That was true when the comment was written, but commit
> f920b0289ba3 (replay: introduce new builtin, 2023-11-24) changed it to
> use git replay without updating this comment.
>
> We could potentially just strike this second comment, since git replay
> is a bonified built-in, but perhaps the explanation about why it focuses
s/bonified/bona fide/ ?
> on git replay is still useful. Update the comment to make it accurate
> again.
>
> Signed-off-by: Elijah Newren <newren@gmail•com>
> ---
next prev parent reply other threads:[~2025-11-07 14:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-03 18:01 [PATCH 0/3] Fix another crazy rename assertion Elijah Newren via GitGitGadget
2025-11-03 18:01 ` [PATCH 1/3] t6429: update comment to mention correct tool Elijah Newren via GitGitGadget
2025-11-07 14:36 ` Kristoffer Haugsbakk [this message]
2025-11-07 22:40 ` Elijah Newren
2025-11-17 1:01 ` Junio C Hamano
2025-11-17 19:54 ` Elijah Newren
2025-11-17 22:10 ` Junio C Hamano
2025-11-03 18:01 ` [PATCH 2/3] merge-ort: remove debugging crud Elijah Newren via GitGitGadget
2025-11-03 18:01 ` [PATCH 3/3] merge-ort: fix failing merges in special corner case Elijah Newren via GitGitGadget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2983385e-daeb-40c0-a8bc-fb8bd3b744a6@app.fastmail.com \
--to=kristofferhaugsbakk@fastmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitgitgadget@gmail$(echo .)com \
--cc=newren@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox