Subject: Re: 7fb9de4a830dd8969bc17a219c509a76dd3c9aad

From: Jon Seymour <[email-masked]>
Date: Tue, 7 Jun 2005 02:05:23 +1000

On 6/7/05, Linus Torvalds <[email-masked]> wrote:
> 
> 
> On Mon, 6 Jun 2005 [email-masked] wrote:
> >
> > [PATCH] Modify git-rev-list to linearise the commit history in merge order.
> 
> Much nicer. Will apply after testing, however, not this part:
> 
> > @@ -110,6 +145,8 @@ static enum cmit_fmt get_commit_format(c
> >       if (!strcmp(arg, "=short"))
> >               return CMIT_FMT_SHORT;
> >       usage(rev_list_usage);
> > +
> > +     return CMIT_FMT_DEFAULT;
> >  }
> >
> >
> 
> If you're bothered by a compiler warning (that I don't see, wonder why?),
> please mark usage() and die() with "__attribute__ ((__noreturn__))". Make
> it depend on GCC, ie
> 
>         #ifdef __GCC__
>         #define NO_RETURN __attribute__((__noreturn__))
>         #else
>         #define NO_RETURN
>         #endif
> 
> and then do
> 
>         extern void die(const char *, ...) NO_RETURN;
> 
> or something like that.
> 
> Anyway, that's indepdendent of this patch, but just fyi.
> 
>                 Linus
> 

Here's my gcc version string:

          gcc (GCC) 3.3.3 20040412 (Red Hat Linux 3.3.3-7)

Shall I resend you the patch with that taken out?

jon.
-- 
homepage: http://www.zeta.org.au/~jon/
blog: http://orwelliantremors.blogspot.com/