From: "René Scharfe" <l.s.r@web•de>
To: Jeff King <peff@peff•net>
Cc: Ross Goldberg <ross.goldberg@gmail•com>,
git@vger•kernel.org, Derrick Stolee <stolee@gmail•com>,
Junio C Hamano <gitster@pobox•com>
Subject: Re: [PATCH] ref-filter: share bases and is_base_tips between formatting and sorting
Date: Sat, 18 Jan 2025 18:11:25 +0100 [thread overview]
Message-ID: <2fbe47c2-22c0-49ff-a211-057bd96ddbc9@web.de> (raw)
In-Reply-To: <20250116102154.GA724126@coredump.intra.peff.net>
Am 16.01.25 um 11:21 schrieb Jeff King:
> And one final thought on this approach: if we do want to do it, perhaps
> it would make sense to build on top of the patch you sent. I think yours
> fixes the bug in a more direct and obvious way, and then my approach
> would merely be internal reorganization on top.
I think moving to the right place in one step requires less churn. Let's
compare; v2 coming up.
René
next prev parent reply other threads:[~2025-01-18 17:16 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-05 9:48 Bug sorting git branch output by ahead-behind:HEAD Ross Goldberg
2025-01-12 10:01 ` [PATCH] ref-filter: share bases and is_base_tips between formatting and sorting René Scharfe
2025-01-13 5:17 ` Jeff King
2025-01-13 5:23 ` Jeff King
2025-01-13 17:25 ` Junio C Hamano
2025-01-14 18:55 ` René Scharfe
2025-01-16 9:51 ` Jeff King
2025-01-16 10:06 ` Jeff King
2025-01-16 10:21 ` Jeff King
2025-01-16 17:31 ` Junio C Hamano
2025-01-18 17:11 ` René Scharfe [this message]
2025-01-19 9:11 ` René Scharfe
2025-01-19 9:11 ` René Scharfe
2025-01-19 9:26 ` René Scharfe
2025-01-19 12:40 ` Jeff King
2025-01-18 17:11 ` René Scharfe
2025-01-18 17:11 ` [PATCH v2 1/3] ref-filter: move ahead-behind bases into used_atom René Scharfe
2025-01-18 17:11 ` [PATCH v2 2/3] ref-filter: move is-base tip to used_atom René Scharfe
2025-01-18 17:11 ` [PATCH v2 3/3] ref-filter: remove ref_format_clear() René Scharfe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2fbe47c2-22c0-49ff-a211-057bd96ddbc9@web.de \
--to=l.s.r@web$(echo .)de \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=peff@peff$(echo .)net \
--cc=ross.goldberg@gmail$(echo .)com \
--cc=stolee@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox