From: "Kristoffer Haugsbakk" <kristofferhaugsbakk@fastmail•com>
To: "Okhuomon Ajayi" <okhuomonajayi54@gmail•com>, git@vger•kernel.org
Subject: Re: [PATCH] [Outreachy] patch-ids: fix NEEDSWORK timezone parsing in fast-import.c
Date: Fri, 10 Oct 2025 01:57:18 +0200 [thread overview]
Message-ID: <3fa266f2-2376-4497-9d36-966fbdb4ca0e@app.fastmail.com> (raw)
In-Reply-To: <20251009234957.1789543-1-okhuomonajayi54@gmail.com>
On Fri, Oct 10, 2025, at 01:49, Okhuomon Ajayi wrote:
> Signed-off-by: Okhuomon Ajayi <okhuomonajayi54@gmail•com>
> ---
> builtin/fast-import.c | 15 ++++++++-------
> 1 file changed, 8 insertions(+), 7 deletions(-)
>
> diff --git a/builtin/fast-import.c b/builtin/fast-import.c
> index 606c6aea82..695e1a0ae1 100644
> --- a/builtin/fast-import.c
> +++ b/builtin/fast-import.c
> @@ -1959,14 +1959,15 @@ static int validate_raw_date(const char *src,
> struct strbuf *result, int strict)
> return -1;
>
> num = strtoul(src + 1, &endp, 10);
> - /*
> - * NEEDSWORK: check for brokenness other than num > 1400, such as
> - * (num % 100) >= 60, or ((num % 100) % 15) != 0 ?
> - */
> - if (errno || endp == src + 1 || *endp || /* did not parse */
> - (strict && (1400 < num)) /* parsed a broken timezone */
> - )
> +
> +
These two new blank lines should probably not be here.
> + unsigned int hours = num / 100;
> + unsigned int minutes = num % 100;
> +
You’re mixing spaces-for-indentation right here with tabs (next). The
project uses tabs for indentation.
Try to run `./ci/check-whitespace.sh @^`
> + if (errno || endp == src + 1 || *endp ||
> + (strict && (num > 1400 || minutes >=60 || minutes % 15 != 0))){
> return -1;
> + }
>
> strbuf_addstr(result, orig_src);
> return 0;
> --
> 2.43.0
next prev parent reply other threads:[~2025-10-09 23:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-09 23:49 [PATCH] [Outreachy] patch-ids: fix NEEDSWORK timezone parsing in fast-import.c Okhuomon Ajayi
2025-10-09 23:57 ` Kristoffer Haugsbakk [this message]
2025-10-10 5:30 ` Patrick Steinhardt
2025-10-10 15:45 ` Junio C Hamano
2025-10-10 17:16 ` Okhuomon Ajayi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3fa266f2-2376-4497-9d36-966fbdb4ca0e@app.fastmail.com \
--to=kristofferhaugsbakk@fastmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=okhuomonajayi54@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox