Subject: Re: [PATCH GSOC] diff: use conventional comparison order

From: Tian Yuchen <[email-masked]>
Date: Sat, 14 Mar 2026 11:59:43 +0800

On 3/14/26 04:18, Junio C Hamano wrote:

> You guessed wrong.  See CodingGuidelines.

It does have nothing to do with the compiler. Thanks for pointing out.

However, the coding guidelines state:

> Both are valid, and we use both.

So, the real key is this sentence:

> Just do not mix styles in the same part of the code and mimic
> existing styles in the neighbourhood.

However, in builtin/add.c before the patch, there isn't even a single 
“>” symbol used for comparison. The “<” symbol is used throughout the 
comparison sections.

I find it quite strange because the author says:

> to follow the common coding style

This patch seems more like it breaks the common coding style.

Regards,

Yuchen