From: "Kristoffer Haugsbakk" <kristofferhaugsbakk@fastmail•com>
To: "Junio C Hamano" <gitster@pobox•com>,
"Andrew Kreimer" <algonell@gmail•com>
Cc: git@vger•kernel.org
Subject: Re: [PATCH v2] doc: fix typos via codespell
Date: Mon, 01 Jun 2026 22:59:09 +0200 [thread overview]
Message-ID: <415f5646-4f4e-48be-a252-8db883f431d9@app.fastmail.com> (raw)
In-Reply-To: <xmqqo6hv9i1w.fsf@gitster.g>
On Mon, Jun 1, 2026, at 03:16, Junio C Hamano wrote:
>[snip]
>
> However, there are things that BREAK tests.
>
>> diff --git a/t/t1700-split-index.sh b/t/t1700-split-index.sh
>> index ac4a5b2734..869fb4a14e 100755
>> --- a/t/t1700-split-index.sh
>> +++ b/t/t1700-split-index.sh
>> @@ -502,7 +502,7 @@ test_expect_success 'do not refresh null base index' '
>> git checkout main &&
>> git update-index --split-index &&
>> test_commit more &&
>> - # must not write a new shareindex, or we wont catch the problem
>> + # must not write a new shareindex, or we won't catch the problem
>> git -c splitIndex.maxPercentChange=100 merge --no-edit side-branch 2>err &&
>> # i.e. do not expect warnings like
>> # could not freshen shared index .../shareindex.00000...
>
> The edit above is made to a STRING that is enclosed inside a pair of
> single quote. If we want to use "won't", we would need to write "We
> won'\''t", but while it may be syntactically correct as a part of
> shell script, it is a pointless change, as the target audience wants
> to see this line as if it is just a plain text.
Sorry about not testing this on v1. “Surely this does not affect the
code...” strikes again.
>
> "We will not" would be acceptable,
>
>> diff --git a/t/t3909-stash-pathspec-file.sh b/t/t3909-stash-pathspec-file.sh
>>[snip]
next prev parent reply other threads:[~2026-06-01 20:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-06 10:15 [PATCH] doc: fix typos via codespell Andrew Kreimer
2026-05-09 22:14 ` Kristoffer Haugsbakk
2026-05-28 17:53 ` Kristoffer Haugsbakk
2026-05-28 20:37 ` Junio C Hamano
2026-05-10 22:21 ` Junio C Hamano
2026-05-23 17:24 ` Weijie Yuan
2026-05-29 8:17 ` [PATCH] docs: fix typos and grammar Weijie Yuan
2026-06-01 22:23 ` Junio C Hamano
2026-06-02 5:58 ` Weijie Yuan
2026-06-02 6:12 ` Weijie Yuan
2026-05-31 18:43 ` [PATCH v2] doc: fix typos via codespell Andrew Kreimer
2026-06-01 1:16 ` Junio C Hamano
2026-06-01 20:59 ` Kristoffer Haugsbakk [this message]
2026-06-02 11:15 ` [PATCH v3] " Andrew Kreimer
2026-06-02 13:57 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=415f5646-4f4e-48be-a252-8db883f431d9@app.fastmail.com \
--to=kristofferhaugsbakk@fastmail$(echo .)com \
--cc=algonell@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox