From: Steven Cole <elenstev@mesatop•com>
To: Petr Baudis <pasky@ucw•cz>
Cc: Sean <seanlkml@sympatico•ca>, Junio C Hamano <junkio@cox•net>,
Marcel Holtmann <marcel@holtmann•org>,
git@vger•kernel.org
Subject: Re: [PATCH] Add cg-printenv command.
Date: Mon, 09 May 2005 07:35:32 -0600 [thread overview]
Message-ID: <427F6724.6010705@mesatop.com> (raw)
In-Reply-To: <20050509072438.GB3599@pasky.ji.cz>
Petr Baudis wrote:
> Dear diary, on Mon, May 09, 2005 at 05:59:59AM CEST, I got a letter
> where Steven Cole <elenstev@mesatop•com> told me that...
>
>>On Sunday 08 May 2005 09:40 pm, Sean wrote:
>>
>>>On Sun, May 8, 2005 11:25 pm, Steven Cole said:
>>>
>>>
>>>>I had intended it only as a quick check by an end-user before doing
>>>>a commit that the values had been set as desired.
>>>
>>>Hey Steven,
>>>
>>>Rather than creating a separate command, perhaps the values could
>>>automatically be added to the initial commit message in a few "CG:" lines?
>
>
> I was already thinking about this and I think Sean's way makes more
> sense. Also, I actually believe you should add this functionality to
> commit-tree instead (commit-tree -n (dry-run), perhaps?) - so that the
> user can actually check the default values commit-tree is going to use
> too. *That* would be useful.
I agree that having a --dry-run option here would be useful. I frequently
use the 't' option when untarring an unfamiliar tarball.
>
>
>>A secondary reason for adding the cg-printenv capability was that a user would
>>see this command in the cg-help list, and cg-help printenv would give:
>
>
> No, I think this sucks. You should just list the variables in cg-commit
> documentation if anything. That's where they matter anyway and where the
> user could possibly look for them anyway.
OK. David has done a good job of documenting this in the git-commit-tree
section of Documentation/core-git.txt, and here is the information again in
the comment header for cg-commit.
That's the way of open source. Post an idea, and any number of superior
implementations come rolling in.
--------
Add comments to cg-commit to point out usage of git environment variables.
Signed-off-by: Steven Cole <elenstev@mesatop•com>
===================================================================
--- 3974261da777f55a7a11aff6e02f584bbfe2b475/cg-commit (mode:100755)
+++ uncommitted/cg-commit (mode:100755)
@@ -13,6 +13,16 @@
# appended to a single commit message, each as separate paragraph.
# -e forces the editor to be brought up even when -m parameters were
# passed to cg-commit.
+#
+#These git environment variables are used in case
+#values other than that returned by getpwuid(getuid())
+#are desired when performing a commit.
+#
+#AUTHOR_NAME Author's name
+#AUTHOR_EMAIL Author's e-mail address
+#AUTHOR_DATE Date, perhaps from a patch e-mail
+#COMMIT_AUTHOR_NAME Committer's name
+#COMMIT_AUTHOR_EMAIL Committer's e-mail address
. ${COGITO_LIB}cg-Xlib
prev parent reply other threads:[~2005-05-09 13:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-09 1:11 [PATCH] Add cg-printenv command Steven Cole
2005-05-09 1:19 ` Marcel Holtmann
2005-05-09 2:38 ` Junio C Hamano
2005-05-09 3:25 ` Steven Cole
2005-05-09 3:40 ` Sean
2005-05-09 3:59 ` Steven Cole
2005-05-09 7:24 ` Petr Baudis
2005-05-09 13:35 ` Steven Cole [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=427F6724.6010705@mesatop.com \
--to=elenstev@mesatop$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=junkio@cox$(echo .)net \
--cc=marcel@holtmann$(echo .)org \
--cc=pasky@ucw$(echo .)cz \
--cc=seanlkml@sympatico$(echo .)ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox