From: "Kristoffer Haugsbakk" <kristofferhaugsbakk@fastmail•com>
To: "Uwe Kleine-König" <u.kleine-koenig@baylibre•com>, git@vger•kernel.org
Subject: Re: [PATCH] Add a config option to add a comment to S-o-b lines
Date: Fri, 20 Mar 2026 12:00:21 +0100 [thread overview]
Message-ID: <4333ce73-9c30-417f-95a4-356362488444@app.fastmail.com> (raw)
In-Reply-To: <20260320102844.2714876-2-u.kleine-koenig@baylibre.com>
On Fri, Mar 20, 2026, at 11:28, Uwe Kleine-König wrote:
> As an employee of a consultant company I'm often requested to mention
> the customer name in the Signed-off-by line. Add a config knob
And this is a widespread practice?
Looking at the Linux Kernel there does seem to be a fair few hits.
> "user.signoffcomment" to configure this and use it in automatically
> generated S-o-b lines.
>
> Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre•com>
> ---
>[snip]
What are the alternatives? I imagine that the commit-msg hook with
git-interpret-trailers(1) could do the same thing.
Adding extra-ident data doesn’t seem to harmonize with grouping by
trailers (git-shortlog(1) with `--group=trailer:`) in the case where the
same person contributes under different orgs or something across the
years. The mailmap can’t be used for trailers. In that light should
git(1) implicitly encourage such a practice over the alternatives like a
separate trailer pre/post the `-by` trailer?
I know it’s not the same thing—just an extension—but git-commit(1)
now says:
Git does not (and will not) have a configuration variable to enable
the --signoff command line option by default; see the commit.signoff
entry in gitfaq(7) for more details.
This does not configure a signoff but it does put more stuff on top of a
“historical mistake”.
next prev parent reply other threads:[~2026-03-20 11:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-20 10:28 [PATCH] Add a config option to add a comment to S-o-b lines Uwe Kleine-König
2026-03-20 11:00 ` Kristoffer Haugsbakk [this message]
2026-03-20 17:06 ` Junio C Hamano
2026-03-20 22:36 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4333ce73-9c30-417f-95a4-356362488444@app.fastmail.com \
--to=kristofferhaugsbakk@fastmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=u.kleine-koenig@baylibre$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox