Subject: Re: [PATCH] Fix gcc-4 warning in accept() call

From: "H. Peter Anvin" <[email-masked]>
Date: Thu, 29 Sep 2005 22:53:43 -0700

Junio C Hamano wrote:
> Pavel Roskin <[email-masked]> writes:
> 
> 
>>gcc-4 warns about sign mismatch in pointers.  Third argument in accept()
>>is socklen_t, which is unsigned.  Since Linus doesn't like socklen_t
>>(see commit 7fa090844f7d1624c7d1ffc621aae6aec84a1110), let's use
>>unsigned int.
> 
> Based on the list comments, I'd drop this patch -- it appears
> that gcc-4 warning is useless in this case.
> 

No, it's not.  The proper type, if you don't use socklen_t, is int, not 
unsigned int.

	-hpa