Subject: Re: [PATCH] Fix compilation of git.c

From: Andreas Ericsson <[email-masked]>
Date: Wed, 16 Nov 2005 07:54:30 +0100

Junio C Hamano wrote:
> Johannes Schindelin <[email-masked]> writes:
> 
> 
>>Some systems do not define GLOB_ABORTED and GLOB_NOMATCH.
> 
> 
> That's true, but the glob does not distinguish executables and
> others anyway, do wouldn't it be more portable and easier to do
> readdir, stat and list in the loop?
> 

Got one implementation of that too, but it doesn't sort the command list 
and I thought it was nice to have them that way while too lazy to 
implement myself.

OTOH, that switch/case thing was for debugging (forgot prefix=/usr when 
compiling...). I'm perfectly fine with

if (glob(....)) {
	error_out("friendly message");
}

-- 
Andreas Ericsson                   [email-masked]
OP5 AB                             www.op5.se
Tel: +46 8-230225                  Fax: +46 8-230231