Subject: Re: [PATCH] off-by-one bugs found by valgrind

From: "H. Peter Anvin" <[email-masked]>
Date: Wed, 21 Dec 2005 13:17:08 -0800

Junio C Hamano wrote:
> Pavel Roskin <[email-masked]> writes:
> 
> 
>>Insufficient memory is allocated in index-pack.c to hold the *.idx name.
>>One more byte should be allocated to hold the terminating 0.
> 
> Thanks.
> 
> 
>>quote_c_style_counted() in quote.c uses a dangerous construct, when a
>>variable is incremented once and used twice in the same expression.
> 
> Sorry, I do not follow you.  Isn't && a sequence point?
> 

&& is a sequence point.  The code is techically fine, but it's harder 
than necessary to read.

	-hpa