From: John Ellson <ellson@research•att.com>
To: Linus Torvalds <torvalds@osdl•org>
Cc: git@vger•kernel.org
Subject: Re: [PATCH] Make GIT-VERSION-GEN tolerate missing git describe command
Date: Fri, 30 Dec 2005 14:12:52 -0500 [thread overview]
Message-ID: <43B586B4.5030001@research.att.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0512301046230.3249@g5.osdl.org>
Linus Torvalds wrote:
> On Fri, 30 Dec 2005, John Ellson wrote:
>
>> I think it is probably a bug that "git non_existent_command"
>> returns its error message to stdout without an error, where
>> "git-non_existent_command" behaves differently and does return an
>> error.
>>
>> Older versions of git did not implement "git describe" and
>> GIT-VERSION-GEN produces an empty version string if run on
>> a system with such a git installed. The consequence
>> is that "make rpm" fails.
>>
>> This patch fixes GIT-VERSION-GEN so that it works in the
>> absence of a working "git describe"
>>
>
> Shouldn't you make "git.c" return an error too, so that "git-describe" and
> "git describe" both fail properly?
>
> I realize that you'd want to do your patch _too_ (in case somebody has an
> old version of "git" installed), but I just think it would be sensible to
> fix the problem that causes this in the first place..
>
> Continuing to output to stdout rather than stderr is probably a good idea
> (so that it's easy to do "git help | less" or something), but yeah, I
> think an unrecognized command should at least return an error.
>
> Linus
>
I checked and that bug has been fixed since the older version of git that
was causing me problems. "git non_existent_command" now returns 1.
However, the error message was also changed to
goto stderr, which it sounds like you disagree with? Personally
I don't have a problem with it, although a real "git-help" command
might be a good idea too.
John
next prev parent reply other threads:[~2005-12-30 19:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-30 16:23 [PATCH] Make GIT-VERSION-GEN tolerate missing git describe command John Ellson
2005-12-30 18:49 ` Linus Torvalds
2005-12-30 19:12 ` John Ellson [this message]
2005-12-30 19:55 ` Linus Torvalds
2005-12-30 19:31 ` John Ellson
2005-12-31 0:15 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43B586B4.5030001@research.att.com \
--to=ellson@research$(echo .)att.com \
--cc=git@vger$(echo .)kernel.org \
--cc=torvalds@osdl$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox