From: Andreas Ericsson <ae@op5•se>
To: Junio C Hamano <junkio@cox•net>
Cc: git@vger•kernel.org
Subject: Re: [PATCH] cvsimport: ease migration from CVSROOT/users format
Date: Sun, 15 Jan 2006 21:50:22 +0100 [thread overview]
Message-ID: <43CAB58E.7090707@op5.se> (raw)
In-Reply-To: <7vbqyd684p.fsf@assigned-by-dhcp.cox.net>
Junio C Hamano wrote:
>
> * Andreas, I also tweaked the regexp to parse the native format
> from /^([^ \t=]*)[ \t=]*([^<]*)(<.*$)\s*/
> to /^(\S+?)\s*=\s*(.+?)\s*<(.+)>\s*$/. I think this tweak is
> correct, but I would appreciate if you can proofread and ACK
> on it. The differences are:
>
It looks correct and seems to do the trick.
> - We grabbed <> pairs and stored in author_email (this is a
> bugfix).
>
gitk showed them as a single such even though theye were passed double.
Perhaps some other tool stripped it along the way? Good catch anyways.
> + }
> + # NEEDSWORK: Maybe warn on unrecognized lines?
> }
I don't think so. I think it's safe to assume that people will check and
double-check that everything's correct before removing the CVS repo, so
it should be easy enough to redo the import (although possibly
time-consuming).
--
Andreas Ericsson andreas.ericsson@op5•se
OP5 AB www.op5.se
Tel: +46 8-230225 Fax: +46 8-230231
prev parent reply other threads:[~2006-01-15 20:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-15 11:30 [PATCH] cvsimport: ease migration from CVSROOT/users format Junio C Hamano
2006-01-15 20:50 ` Andreas Ericsson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43CAB58E.7090707@op5.se \
--to=ae@op5$(echo .)se \
--cc=git@vger$(echo .)kernel.org \
--cc=junkio@cox$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox