From: A Large Angry SCM <gitzilla@gmail•com>
To: Junio C Hamano <junkio@cox•net>
Cc: git@vger•kernel.org
Subject: Re: Git 1.1.6.g4d44 make test FAILURE report
Date: Fri, 10 Feb 2006 19:52:00 -0800 [thread overview]
Message-ID: <43ED5F60.1010408@gmail.com> (raw)
In-Reply-To: <7vvevmtza4.fsf@assigned-by-dhcp.cox.net>
Junio C Hamano wrote:
> A Large Angry SCM <gitzilla@gmail•com> writes:
>
>>Also, git-var complains when used by an account with an empty gcos
>>field; thereby, breaking all the non-C git commands even when the user
>>is not committing.
>>
>>If the _intent_ was to force commiters and author names in commits,
>>why was the test not placed only in commit-tree.c?
>
> git-var was more or less intentional. Scripts such as
> git-applypatch, git-commit and git-tag use the command to grab
> COMMITTER_IDENT to generate sign-off line and tagger information
> when asked, and commit-tree.c changes alone would not catch
> them.
>
> A user eventually would make commit so it may not be a too bad
> to _strongly_ encourage setting up these environment variables,
> by being nasty ;-). I agree it would be _very_ annoying until
> you either fix your gecos and/or environment.
>
> Ideas welcome.
It also breaks a lot of commands not related to making commits;
git-fetch for one.
next prev parent reply other threads:[~2006-02-11 3:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-10 21:19 Git 1.1.6.g4d44 make test FAILURE report A Large Angry SCM
2006-02-10 21:38 ` Junio C Hamano
2006-02-11 1:37 ` A Large Angry SCM
2006-02-11 2:17 ` Junio C Hamano
2006-02-11 3:52 ` A Large Angry SCM [this message]
2006-02-11 4:14 ` Junio C Hamano
2006-02-11 4:43 ` Junio C Hamano
2006-02-11 12:10 ` [PATCH] Teach repo-config the -l and --get-regexp options Johannes Schindelin
2006-02-12 3:05 ` Junio C Hamano
2006-02-12 3:14 ` [PATCH] Add support for explicit type specifiers when calling git-repo-config Petr Baudis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43ED5F60.1010408@gmail.com \
--to=gitzilla@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=junkio@cox$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox