public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed
From: Ryan Anderson <ryan@michonline•com>
To: gitzilla@gmail•com
Cc: Martin Langhoff <martin.langhoff@gmail•com>,
	Fredrik Kuivinen <freku045@student•liu.se>,
	git@vger•kernel.org, junkio@cox•net
Subject: Re: [PATCH] annotate: Support annotation of files on other revisions.
Date: Mon, 06 Mar 2006 00:40:55 -0500	[thread overview]
Message-ID: <440BCB67.4070406@michonline.com> (raw)
In-Reply-To: <440BC92E.4060306@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 640 bytes --]

A Large Angry SCM wrote:

> Ryan Anderson wrote:
> ...
>
>>
>> For annotate, the syntax I was using was:
>>     git annotate Makefile headname
>>
>> I'm not married to it, so please, send a patch to change it if you want
>> (Please fix up the test case I'm sending in this patch, as well.)
>>
>
> Wouldn't
>     git annotate <headname> <filename(s?)>
> be more consistent with other git commands?
>
Yes, but <headname> (really, a commitish) needs to be optional.

I should probably switch to:
    git annotate [-c|--commit <committish>] <filename>
but that's partly why I'm asking for feedback.


-- 

Ryan Anderson
  sometimes Pug Majere


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 256 bytes --]

  reply	other threads:[~2006-03-06  5:50 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-03-05 11:13 [PATCH] git-blame: Use the same tests for git-blame as for git-annotate Fredrik Kuivinen
2006-03-05 23:32 ` Ryan Anderson
2006-03-06  0:19   ` Junio C Hamano
2006-03-06  0:29   ` Martin Langhoff
2006-03-06  2:43     ` [PATCH] annotate: Support annotation of files on other revisions Ryan Anderson
2006-03-06  4:18       ` Martin Langhoff
2006-03-06  7:49         ` Fredrik Kuivinen
2006-03-06  5:31       ` A Large Angry SCM
2006-03-06  5:40         ` Ryan Anderson [this message]
2006-03-06  5:50           ` Shawn Pearce
2006-03-06  6:16             ` Junio C Hamano
2006-03-06  6:32               ` Shawn Pearce
2006-03-06  6:21             ` A Large Angry SCM
2006-03-06  6:28               ` Junio C Hamano
2006-03-06  9:24                 ` Johannes Schindelin
2006-03-06  9:18       ` Johannes Schindelin
2006-03-06 15:44         ` Ryan Anderson
2006-03-06  2:56 ` [PATCH] git-blame: Use the same tests for git-blame as for git-annotate Ryan Anderson
2006-03-06  6:12   ` [PATCH] annotate/blame tests updates Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=440BCB67.4070406@michonline.com \
    --to=ryan@michonline$(echo .)com \
    --cc=freku045@student$(echo .)liu.se \
    --cc=git@vger$(echo .)kernel.org \
    --cc=gitzilla@gmail$(echo .)com \
    --cc=junkio@cox$(echo .)net \
    --cc=martin.langhoff@gmail$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox