From: phillip.wood123@gmail•com
To: Seyi Kuforiji <kuforiji98@gmail•com>, git@vger•kernel.org
Cc: ps@pks•im, phillip.wood@dunelm•org.uk
Subject: Re: [PATCH 0/5] t/unit-tests: convert unit-tests to use clar
Date: Fri, 21 Feb 2025 14:52:12 +0000 [thread overview]
Message-ID: <443ecd89-785f-4985-8666-e8caae33306b@gmail.com> (raw)
In-Reply-To: <20250220082959.10854-1-kuforiji98@gmail.com>
Hi Seyi
On 20/02/2025 08:29, Seyi Kuforiji wrote:
> Hello,
>
> This small patch series transitions a couple more of our existing unit
> test files to the Clar testing framework. This change is part of our
> ongoing effort to standardize our testing framework to enhance
> maintainability.
Overall I think the conversions are correct, but we'd be better to keep
the diagnostic messages by using cl_failf().
Best Wishes
Phillip
> Thanks
> Seyi
>
> Mentored-by: Patrick Steinhardt <ps@pks•im>
> Signed-off-by: Seyi Kuforiji <kuforiji98@gmail•com>
>
> Seyi Kuforiji (5):
> t/unit-tests: implement oid helper functions in unit-tests.{c,h}
> t/unit-tests: convert oid-array test to use clar test framework
> t/unit-tests: convert oidmap test to use clar test framework
> t/unit-tests: convert oidtree test to use clar test framework
> t/unit-tests: remove lib-oid.{c,h,o}
>
> Makefile | 7 +-
> t/meson.build | 7 +-
> t/unit-tests/lib-oid.c | 52 ------
> t/unit-tests/lib-oid.h | 25 ---
> t/unit-tests/{t-oid-array.c => u-oid-array.c} | 123 +++++++-------
> t/unit-tests/{t-oidmap.c => u-oidmap.c} | 153 ++++++------------
> t/unit-tests/{t-oidtree.c => u-oidtree.c} | 78 ++++-----
> t/unit-tests/unit-test.c | 42 +++++
> t/unit-tests/unit-test.h | 19 +++
> 9 files changed, 212 insertions(+), 294 deletions(-)
> delete mode 100644 t/unit-tests/lib-oid.c
> delete mode 100644 t/unit-tests/lib-oid.h
> rename t/unit-tests/{t-oid-array.c => u-oid-array.c} (35%)
> rename t/unit-tests/{t-oidmap.c => u-oidmap.c} (32%)
> rename t/unit-tests/{t-oidtree.c => u-oidtree.c} (44%)
>
next prev parent reply other threads:[~2025-02-21 14:52 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-20 8:29 [PATCH 0/5] t/unit-tests: convert unit-tests to use clar Seyi Kuforiji
2025-02-20 8:29 ` [PATCH 1/5] t/unit-tests: implement oid helper functions in unit-tests.{c,h} Seyi Kuforiji
2025-02-20 14:38 ` Phillip Wood
2025-02-21 7:59 ` Patrick Steinhardt
2025-02-21 7:59 ` Patrick Steinhardt
2025-02-21 14:50 ` phillip.wood123
2025-02-20 8:29 ` [PATCH 2/5] t/unit-tests: convert oid-array test to use clar Seyi Kuforiji
2025-02-20 14:38 ` Phillip Wood
2025-02-24 9:11 ` Seyi Chamber
2025-02-24 10:12 ` phillip.wood123
2025-02-20 8:29 ` [PATCH 3/5] t/unit-tests: convert oidmap " Seyi Kuforiji
2025-02-21 10:04 ` phillip.wood123
2025-02-24 10:56 ` Seyi Chamber
2025-02-20 8:29 ` [PATCH 4/5] t/unit-tests: convert oidtree " Seyi Kuforiji
2025-02-21 14:48 ` phillip.wood123
2025-02-20 8:29 ` [PATCH 5/5] t/unit-tests: remove lib-oid.{c,h,o} Seyi Kuforiji
2025-02-21 14:52 ` phillip.wood123 [this message]
2025-02-24 15:27 ` [PATCH v2 0/4] t/unit-tests: convert unit-tests to use clar Seyi Kuforiji
2025-02-24 15:27 ` [PATCH v2 1/4] t/unit-tests: implement clar specific oid helper functions Seyi Kuforiji
2025-02-24 17:55 ` Junio C Hamano
2025-02-25 7:14 ` Seyi Chamber
2025-02-25 7:56 ` Patrick Steinhardt
2025-02-24 15:27 ` [PATCH v2 2/4] t/unit-tests: convert oid-array test to use clar test framework Seyi Kuforiji
2025-02-24 15:27 ` [PATCH v2 3/4] t/unit-tests: convert oidmap " Seyi Kuforiji
2025-02-24 15:27 ` [PATCH v2 4/4] t/unit-tests: convert oidtree " Seyi Kuforiji
2025-02-25 10:10 ` [PATCH v3 0/4] t/unit-tests: convert unit-tests to use clar Seyi Kuforiji
2025-02-25 10:10 ` [PATCH v3 1/4] t/unit-tests: implement clar specific oid helper functions Seyi Kuforiji
2025-02-25 10:10 ` [PATCH v3 2/4] t/unit-tests: convert oid-array test to use clar test framework Seyi Kuforiji
2025-02-25 10:10 ` [PATCH v3 3/4] t/unit-tests: convert oidmap " Seyi Kuforiji
2025-02-25 10:10 ` [PATCH v3 4/4] t/unit-tests: convert oidtree " Seyi Kuforiji
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=443ecd89-785f-4985-8666-e8caae33306b@gmail.com \
--to=phillip.wood123@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=kuforiji98@gmail$(echo .)com \
--cc=phillip.wood@dunelm$(echo .)org.uk \
--cc=ps@pks$(echo .)im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox