Subject: Re: [PATCH] git-sh-setup: Fail if the git directory was not found.

From: Robert Shearman <[email-masked]>
Date: Sun, 13 Aug 2006 12:52:36 +0100

Junio C Hamano wrote:

>Junio C Hamano <[email-masked]> writes:
>
>  
>
>>Moving the assignment of GIT_OBJECT_DIRECTORY is fine, but
>>changing it to an unconditional assignment is wrong.  The user
>>can have a GIT_OBJECT_DIRECTORY set independently from GIT_DIR
>>(or ../some/where/.git that is detected).
>>    
>>

I'm not an expert in shell scripting so I didn't notice that it was a 
conditional assignment.

>How about this as a replacement?
>  
>

Looks good.

Thanks,

-- 
Rob Shearman