From: "René Scharfe" <l.s.r@web•de>
To: Git List <git@vger•kernel.org>
Subject: [PATCH] commit-reach: stop sorting in paint_down_to_common()
Date: Wed, 27 May 2026 17:52:17 +0200 [thread overview]
Message-ID: <450163b0-82c8-4b57-baab-a269efe430aa@web.de> (raw)
None of the three callers of paint_down_to_common() care about the order
of its result list: merge_bases_many() sorts it again after removing
stale items, remove_redundant_no_gen() and repo_in_merge_bases_many()
throw the list away without even looking at it. So drop the unnecessary
commit_list_sort_by_date() call.
Signed-off-by: René Scharfe <l.s.r@web•de>
---
commit-reach.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/commit-reach.c b/commit-reach.c
index 5a52be90a6..056a7ed8d8 100644
--- a/commit-reach.c
+++ b/commit-reach.c
@@ -137,7 +137,6 @@ static int paint_down_to_common(struct repository *r,
}
clear_prio_queue(&queue);
- commit_list_sort_by_date(result);
return 0;
}
--
2.54.0
next reply other threads:[~2026-05-27 15:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-27 15:52 René Scharfe [this message]
2026-05-29 8:43 ` [PATCH] commit-reach: stop sorting in paint_down_to_common() Jeff King
2026-05-29 15:32 ` René Scharfe
2026-05-29 19:04 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=450163b0-82c8-4b57-baab-a269efe430aa@web.de \
--to=l.s.r@web$(echo .)de \
--cc=git@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox