public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: "Алексей Шумкин" <zapped@mail•ru>
To: Thomas Rast <trast@student•ethz.ch>
Cc: git@vger•kernel.org
Subject: Re[2]: [PATCH 1/3] Fixes bug: git-diff: class methods are not detected in hunk headers for Pascal
Date: Wed, 5 Jan 2011 14:53:02 +0300	[thread overview]
Message-ID: <4510264083.20110105145302@mail.ru> (raw)
In-Reply-To: <201101041813.45053.trast@student.ethz.ch>

Hello, Thomas

TR> But the last line very conspicuously already mentions 'class', so why
TR> does it fail?
Yes, As you already discovered that last line match for class/record
definition but not for class methods.

I did as you said I changed commit message (also included
"Acked-by:"). So should I re-submit patch to the maillist as a new one
or as an answer to this thread?

TR> Zapped wrote:
>> Signed-off-by: Zapped <zapped@mail•ru>

TR> As Junio already said, please provide a real name for the sign-off.
TR> But I also found the commit message and content confusing, probably
TR> because I haven't programmed Pascal for 15 years.

TR> You said

TR>   Fixes bug: git-diff: class methods are not detected in hunk headers for Pascal

>>  PATTERNS("pascal",
>> -      "^((procedure|function|constructor|destructor|interface|"
>> +      "^(((class[ \t]+)?(procedure|function)|constructor|destructor|interface|"
>>               "implementation|initialization|finalization)[ \t]*.*)$"
>>        "\n"
>>        "^(.*=[ \t]*(class|record).*)$",

TR> But the last line very conspicuously already mentions 'class', so why
TR> does it fail?

TR> I had to look up a bit of Pascal syntax.  Google helped with

TR>   http://www.freepascal.org/docs-html/ref/ref.html

TR> which answers this.  Also, as stated in SubmittingPatches, we
TR> generally word the messages as stating the behaviour of the changed
TR> version in the present tense.  So a better commit message would be

TR>   userdiff: match Pascal class methods

TR>   Class declarations were already covered by the second pattern, but
TR>   class methods have the 'class' keyword in front too.  Account for
TR>   it.

TR>   Signed-off-by: Алексей Крезов <zapped@mail•ru>

TR> Ok, now I feel silly for only having a two-liner despite my
TR> complaints.

TR> That being said, I have now verified that the patch is good, and, you
TR> can include my

TR>   Acked-by: Thomas Rast <trast@student•ethz.ch>

TR> in a reroll if you fix the above.

next prev parent reply	other threads:[~2011-01-05 11:52 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-25  1:20 [PATCH 1/3] Fixes bug: git-diff: class methods are not detected in hunk headers for Pascal Zapped
2010-12-25  1:20 ` [PATCH 2/3] Fixes bug: git-svn: svn.pathnameencoding is not respected with dcommit/set-tree Zapped
2011-01-04 17:18   ` Thomas Rast
2011-01-04 23:20     ` Eric Wong
2011-02-03 20:28       ` Alexey Shumkin
2011-01-05 11:44     ` Re[2]: " Алексей Шумкин
2010-12-25  1:20 ` [PATCH 3/3] Fixes bug: GIT_PS1_SHOWDIRTYSTATE is no not respect diff.ignoreSubmodules config variable Zapped
2010-12-25 12:33   ` Jens Lehmann
2010-12-25 13:08     ` Johannes Schindelin
2010-12-26 19:14     ` Junio C Hamano
2010-12-26 22:42       ` Re[2]: " Алексей Шумкин
2010-12-27 11:14       ` Jens Lehmann
2010-12-27 22:06         ` Johannes Schindelin
2010-12-27 22:43           ` Casey Dahlin
2010-12-26 22:25     ` Re[2]: " Алексей Крезов
2010-12-28 12:14     ` Алексей Шумкин
2011-01-04 17:13 ` [PATCH 1/3] Fixes bug: git-diff: class methods are not detected in hunk headers for Pascal Thomas Rast
2011-01-05 11:53   ` Алексей Шумкин [this message]
2011-01-05 14:23     ` Thomas Rast
2011-01-05 14:31       ` Thomas Rast

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4510264083.20110105145302@mail.ru \
    --to=zapped@mail$(echo .)ru \
    --cc=git@vger$(echo .)kernel.org \
    --cc=trast@student$(echo .)ethz.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox