public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed
From: Thomas Guyot <tguyot@gmail•com>
To: usharerose <ushareroses@gmail•com>, git@vger•kernel.org
Subject: Re: [DISCUSS] validation on git config user.email
Date: Fri, 12 Sep 2025 11:39:41 -0400	[thread overview]
Message-ID: <45640ca0-b3c5-4627-b41a-0b58ff559d2b@gmail.com> (raw)
In-Reply-To: <CAJKmQvf-sLxowLJLitvqDmyL1BXXDK+anDE2jaBSEabApMNVoQ@mail.gmail.com>

On 2025-09-12 00:13, usharerose wrote:
> 
> I'm interested in understanding the design philosophy or historical
> reasons behind this 'lack' of validation.
> 

Hi usharerose,

To add to the other valid responses, email is something that can be 
validated by hooks server-side to enforce not only proper formatting but 
also valid users are being used, ex. validating against an LDAP directory.

This is much better that validating it at the command level (although 
IIRC git-comit does warn about possibly unset/invalid email addresses). 
In addition, unless git starts enforcing stricter rules on the commit 
message format (which would be a breaking change), nothing else can 
prevent someone from constructing commits with invalid emails, so checks 
by git-commit alone can't be strictly enforceable.

Furthermore, imported commits from other SCMs may have odd user 
name/email and it may be desirable to keep then in their original 
formats rather than turning them into fake email addresses.

Regards,

--
Thomas

  parent reply	other threads:[~2025-09-12 15:39 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-12  4:13 [DISCUSS] validation on git config user.email usharerose
2025-09-12 15:00 ` rsbecker
2025-09-12 16:29   ` Junio C Hamano
2025-09-12 18:06     ` usharerose
2025-09-12 16:52   ` usharerose
2025-09-12 17:23     ` rsbecker
2025-09-12 17:44       ` usharerose
2025-09-14 11:17   ` Kristoffer Haugsbakk
2025-09-14 16:59     ` rsbecker
2025-09-12 15:13 ` Konstantin Ryabitsev
2025-09-12 15:39 ` Thomas Guyot [this message]
2025-09-12 18:02   ` usharerose
2025-09-14 11:58 ` Kristoffer Haugsbakk
2025-09-15 13:40   ` usharerose

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45640ca0-b3c5-4627-b41a-0b58ff559d2b@gmail.com \
    --to=tguyot@gmail$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=ushareroses@gmail$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox