Subject: Re: [PATCH] fetch-pack: remove --keep-auto and make it the default.

From: Johannes Sixt <[email-masked]>
Date: Fri, 26 Jan 2007 09:37:15 +0100

Junio C Hamano wrote:
> 
> Johannes Schindelin <[email-masked]> writes:
> 
> > On Wed, 24 Jan 2007, Junio C Hamano wrote:
> >
> >>   Ok, how about this, on top of the previous ones?
> >
> > Thanks!
> >
> >> @@ -653,6 +663,8 @@ int main(int argc, char **argv)
> >>      struct stat st;
> >>
> >>      setup_git_directory();
> >> +    setup_ident();
> >> +    git_config(fetch_pack_config);
> >
> > Why do you need setup_ident()?
> 
> Because presumably you would be updating the reflog that records
> who did the fetch?
> 
> But then we should do the same ignore_missing_committer_name()
> we have in receive-pack to allow anonymous fetchers to fetch
> from outside world, I guess.

Instead of using ignore_missing_committer_name(), use
get_committer_info(0) in refs.c. cherry-pick 4feaf032d3 from my tree at
git://repo.or.cz/git/mingw.git if you want.

Although this approach leaves the name+email in the reflog entry empty
instead of writing "unkown"...

-- Hannes