From: Mark Levedahl <mdl123@verizon•net>
To: Johannes Schindelin <Johannes.Schindelin@gmx•de>
Cc: git@vger•kernel.org, junkio@cox•net, Nicolas Pitre <nico@cam•org>,
Simon 'corecode' Schubert <corecode@fs•ei.tum.de>
Subject: Re: [PATCH] git-bundle: assorted fixes
Date: Thu, 22 Feb 2007 22:37:53 -0500 [thread overview]
Message-ID: <45DE6191.5030200@verizon.net> (raw)
In-Reply-To: <Pine.LNX.4.63.0702230316570.22628@wbgn013.biozentrum.uni-wuerzburg.de>
Johannes Schindelin wrote:
>
> On Thu, 22 Feb 2007, Mark Levedahl wrote:
>
>> Johannes Schindelin wrote:
>>
>>> Mark wrote:
>>>
>>>> 2) git bundle verify reports only a single sha1 if prerequisites are
>>>> not met.
>>> With the two follow-up patches I sent, this issue should be resolved,
>>> no?
>>>
>> I missed one of your patches, adding that, the problem is incompletely
>> fixed: all missing commits are shown, but only as raw hashes (e.g., the
>> 1-line commit message is not there to describe what is missing).
>
> Okay, how about this on top:
>
>
That works. I would change your error message slightly, perhaps...
diff --git a/builtin-bundle.c b/builtin-bundle.c
index d74afaa..e115feb 100644
--- a/builtin-bundle.c
+++ b/builtin-bundle.c
@@ -172,7 +172,7 @@ static int verify_bundle(struct bundle_header *header)
struct object_array refs;
struct commit *commit;
int i, ret = 0, req_nr;
- const char *message = "The bundle requires these lacking revs:";
+ const char *message = "Your repository lacks these prerequisite
commits:";
init_revisions(&revs, NULL);
for (i = 0; i < p->nr; i++) {
Mark
prev parent reply other threads:[~2007-02-23 3:38 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Pine.LNX.4.63.0702220157130.22628@wbgn013.biozentrum.uni-wuerz burg.de>
2007-02-22 0:59 ` [PATCH] Add git-bundle: move objects and references by archive Johannes Schindelin
2007-02-22 3:28 ` Nicolas Pitre
2007-02-22 15:55 ` Johannes Schindelin
2007-02-22 16:14 ` Simon 'corecode' Schubert
2007-02-22 16:28 ` Nicolas Pitre
2007-02-22 16:37 ` Johannes Schindelin
2007-02-22 16:46 ` Simon 'corecode' Schubert
2007-02-22 17:09 ` Johannes Schindelin
2007-02-22 16:24 ` Nicolas Pitre
2007-02-22 17:12 ` Johannes Schindelin
2007-02-22 17:21 ` Nicolas Pitre
2007-02-22 6:56 ` Junio C Hamano
2007-02-22 7:08 ` Junio C Hamano
2007-02-22 16:20 ` Johannes Schindelin
2007-02-22 19:10 ` Junio C Hamano
2007-02-22 19:16 ` Johannes Schindelin
2007-02-22 20:05 ` Junio C Hamano
2007-02-22 20:25 ` Johannes Schindelin
2007-02-22 16:17 ` Johannes Schindelin
2007-02-23 2:32 ` Mark Levedahl
2007-02-23 4:39 ` Junio C Hamano
2007-02-22 9:31 ` Johannes Sixt
2007-02-22 18:14 ` [PATCH] git-bundle: assorted fixes Johannes Schindelin
2007-02-23 1:36 ` Mark Levedahl
2007-02-23 1:56 ` Johannes Schindelin
2007-02-23 2:12 ` Mark Levedahl
2007-02-23 2:17 ` Johannes Schindelin
2007-02-23 3:37 ` Mark Levedahl [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45DE6191.5030200@verizon.net \
--to=mdl123@verizon$(echo .)net \
--cc=Johannes.Schindelin@gmx$(echo .)de \
--cc=corecode@fs$(echo .)ei.tum.de \
--cc=git@vger$(echo .)kernel.org \
--cc=junkio@cox$(echo .)net \
--cc=nico@cam$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox