From: "Kristoffer Haugsbakk" <kristofferhaugsbakk@fastmail•com>
To: "Junio C Hamano" <gitster@pobox•com>, git@vger•kernel.org
Subject: Re: What's cooking in git.git (Dec 2025, #09)
Date: Tue, 30 Dec 2025 15:33:19 +0100 [thread overview]
Message-ID: <460f1f96-4236-4d19-bdfa-6c86bad811c5@app.fastmail.com> (raw)
In-Reply-To: <xmqqa4z0f5dq.fsf@gitster.g>
On Tue, Dec 30, 2025, at 14:47, Junio C Hamano wrote:
> * kh/replay-invalid-onto-advance (2025-12-22) 2 commits
> - t3650: add more regression tests for failure conditions
> - replay: die descriptively when invalid commit-ish
>
> Test coverage of "git replay" has been improved.
The main change is a better error message when you give a bad argument
to `--onto`. The improved test coverage is secondary but related since
the coverage for simple die conditions (like bad `--onto` argument) is
poor. (Like the mistake that you pointed out;[1] I was about to make the
error message for `--advance` slightly worse. But the test for “argument
to --advance must be a reference” will make it harder for me to make
that mistake in the future.)
The second version is coming now.
🔗 1: https://lore.kernel.org/git/xmqqpl85pb7k.fsf@gitster.g/
>
> Expecting a rework on the bottom patch.
> source: <CV_replay_die_descr.13f@msgid•xyz>
next prev parent reply other threads:[~2025-12-30 14:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-30 13:47 What's cooking in git.git (Dec 2025, #09) Junio C Hamano
2025-12-30 14:33 ` Kristoffer Haugsbakk [this message]
2025-12-30 14:43 ` K Jayatheerth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=460f1f96-4236-4d19-bdfa-6c86bad811c5@app.fastmail.com \
--to=kristofferhaugsbakk@fastmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox