Subject: Re: [PATCH] missing return

From: Jerald Fitzjerald <[email-masked]>
Date: Wed, 30 May 2007 12:16:45 -0700

Junio C Hamano wrote:

>I realize that I've seen this pointed out by somebody already.
>
It was suggested on irc a couple of days ago.

Signed-off-by: Jerald Fitzjerald <[email-masked]>

---

diff --git a/base85.c b/base85.c
--- a/base85.c
+++ b/base85.c
@@ -66,7 +66,7 @@ int decode_85(char *dst, const char *buf
		 */
		if (0x03030303 < acc ||
		    0xffffffff - de < (acc *= 85))
-			error("invalid base85 sequence %.5s", buffer-5);
+			return error("invalid base85 sequence %.5s", buffer-5);
		acc += de;
		say1(" %08x", acc);