Subject: Re: [PATCH] Add basic test-script for git-submodule

From: Johannes Sixt <[email-masked]>
Date: Fri, 01 Jun 2007 09:56:12 +0200

Lars Hjemli wrote:
> +test_expect_success 'status should only print one line' '
> +       lines=$(git-submodule status | wc -l)

&& is missing.

> +       test "$lines" = "1"

Please don't put output of wc in quotes because some versions of wc emit
padding:

	test $lines = 1

(without the quotes around 1 - like in other test scripts).

-- Hannes