From: Sam Vilain <sam@vilain•net>
To: Eric Wong <normalperson@yhbt•net>
Cc: git@vger•kernel.org
Subject: Re: [PATCH] git-svn: cache max revision in rev_db databases
Date: Mon, 11 Jun 2007 23:43:54 +1200 [thread overview]
Message-ID: <466D357A.8070605@vilain.net> (raw)
In-Reply-To: <20070610214753.GC12222@muzzle>
Eric Wong wrote:
> Sam Vilain <sam@vilain•net> wrote:
>
>> Cache the maximum revision for each rev_db URL rather than looking it
>> up each time. This saves a lot of time when rebuilding indexes on a
>> freshly cloned repository.
>>
>
> It looks correct, but I'm not sure how often we can even hit this
> optimization to make it worth it.
>
> Any live repositories and benchmarks you've run this on?
> (without the rev-list => log patch applied, which would be a big
> performance improvement if all log messages were under 16k).
>
It may not make a huge difference with the current code, but it might
with a different rev_db back-end with higher connection cost, and it
seemed like an obvious and innocuous enough memoization.
Sam
next prev parent reply other threads:[~2007-06-11 11:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-10 9:04 [PATCH] git-svn: cache max revision in rev_db databases Sam Vilain
2007-06-10 21:47 ` Eric Wong
2007-06-11 11:43 ` Sam Vilain [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-06-30 8:56 a bunch of outstanding updates Sam Vilain
2007-06-30 8:56 ` [PATCH] repack: improve documentation on -a option Sam Vilain
2007-06-30 8:56 ` [PATCH] git-svn: use git-log rather than rev-list | xargs cat-file Sam Vilain
2007-06-30 8:56 ` [PATCH] git-svn: cache max revision in rev_db databases Sam Vilain
2007-07-01 3:50 ` Junio C Hamano
2007-07-01 5:31 ` Eric Wong
2007-07-01 6:49 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=466D357A.8070605@vilain.net \
--to=sam@vilain$(echo .)net \
--cc=git@vger$(echo .)kernel.org \
--cc=normalperson@yhbt$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox