Subject: Re: [PATCH 1/3] Export format_commit_message()

From: René Scharfe <[email-masked]>
Date: Mon, 03 Sep 2007 20:44:10 +0200

Johannes Schindelin schrieb:
>> -static long format_commit_message(const struct commit *commit,
>> -		const char *msg, char **buf_p, unsigned long *space_p)
>> +long format_commit_message(const struct commit *commit, const void *template,
>> +                           char **buf_p, unsigned long *space_p)
> 
> I am quite sure that this breaks compilation in C++.
> 
> Besides, "format" is so much more descriptive here IMHO.  What is so wrong 
> with "format" for you?

I have nothing against naming the parameter "format", actually.  This
name simply didn't occur to me -- weird but true. :-]

René