Subject: Re: [PATCH 1/3] Fixing path quoting in git-rebase

From: Johannes Sixt <[email-masked]>
Date: Mon, 15 Oct 2007 15:39:30 +0200

Jonathan del Strother schrieb:
> -	eval GITHEAD_$hd='"$(cat $dotest/onto_name)"'
> +	eval GITHEAD_$hd='"$(cat \"$dotest/onto_name\")"'

I believe this is not correct. It should be this way:

	eval GITHEAD_$hd='$(cat "$dotest/onto_name")'

You can test it with a conflicting git-rebase -m. It only affects what the 
conflict markers look like. The test suite does not test it.

The rest looks good.

-- Hannes