Subject: Re: [PATCH 2/3] launch_editor(): read the file, even when EDITOR=:

From: Johannes Sixt <[email-masked]>
Date: Thu, 08 Nov 2007 13:33:38 +0100

Johannes Schindelin schrieb:
> +		struct child_process child;
> +		memset(&child, 0, sizeof(child));
> +		child.argv = args;
> +		args[0] = editor;
> +		args[1] = path;
> +		args[2] = NULL;
>  
> +		if (run_command(&child))

You can shorten this to

		const char *args[] = { editor, path, NULL };
		if (run_command_v_opt(args, 0))

(and possibly remove 'args' that is in the surrounding block).

-- Hannes