From: Andreas Ericsson <ae@op5•se>
To: Jon Loeliger <jdl@freescale•com>
Cc: Junio C Hamano <gitster@pobox•com>,
Pierre Habouzit <madcoder@debian•org>,
git@vger•kernel.org
Subject: Re: [PATCH MISC 1/1] Make gcc warning about empty if body go away.
Date: Thu, 08 Nov 2007 16:47:26 +0100 [thread overview]
Message-ID: <47332F8E.8080309@op5.se> (raw)
In-Reply-To: <47332957.5050308@freescale.com>
Jon Loeliger wrote:
> Andreas Ericsson wrote:
>
>>> + if (active_cache_changed &&
>>> + !write_cache(fd, active_cache, active_nr) && !close(fd))
>>> + commit_locked_index(lock_file);
>>> rollback_lock_file(lock_file);
>>> }
>>>
>>
>> Ack, obviously, as it no longer requires a comment to explain it,
>> although
>> I'd prefer an empty line after commit_locked_index(lock_file); so as
>> to not
>> confuse the rollback_lock_file() statement as being part of the
>> conditional
>> path.
>>
>> First I thought the rollback_lock_file() was the *only* statement to the
>> condition, and everyone who uses 4 for tabsize) will have double trouble
>> since commit_locked_index(lock_file) aligns with the second line of the
>> condition.
>>
>
> It's too bad this was confusing due to the lack of braces. :-)
>
I found that slightly ironic too, since I really don't like overly bracey
code either. Just goes to show there are no rules without exceptions, I
guess.
--
Andreas Ericsson andreas.ericsson@op5•se
OP5 AB www.op5.se
Tel: +46 8-230225 Fax: +46 8-230231
prev parent reply other threads:[~2007-11-08 15:48 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-07 10:20 Preliminary patches to the diff.[hc] parseoptification Pierre Habouzit
2007-11-07 10:20 ` [PATCH MISC 1/1] Make gcc warning about empty if body go away Pierre Habouzit
2007-11-07 10:20 ` [PATCH PARSEOPT 1/4] parse-options new features Pierre Habouzit
2007-11-07 10:20 ` [PATCH PARSEOPT 2/4] Use OPT_SET_INT and OPT_BIT in builtin-branch Pierre Habouzit
2007-11-07 10:20 ` [PATCH PARSEOPT 3/4] Use OPT_BIT in builtin-for-each-ref Pierre Habouzit
2007-11-07 10:20 ` [PATCH PARSEOPT 4/4] Use OPT_BIT in builtin-pack-refs Pierre Habouzit
2007-11-07 10:20 ` [PATCH DIFF-CLEANUP 1/2] Make the diff_options bitfields be an unsigned with explicit masks Pierre Habouzit
2007-11-07 10:20 ` [PATCH DIFF-CLEANUP 2/2] Reorder diff_opt_parse options more logically per topics Pierre Habouzit
2007-11-08 6:39 ` [PATCH DIFF-CLEANUP 1/2] Make the diff_options bitfields be an unsigned with explicit masks Junio C Hamano
2007-11-08 8:17 ` Pierre Habouzit
2007-11-10 19:05 ` [UPDATE " Pierre Habouzit
2007-11-08 23:59 ` [PATCH PARSEOPT 1/4] parse-options new features Junio C Hamano
2007-11-09 0:17 ` Pierre Habouzit
2007-11-08 1:52 ` [PATCH MISC 1/1] Make gcc warning about empty if body go away Junio C Hamano
2007-11-08 2:01 ` Junio C Hamano
2007-11-08 8:12 ` Pierre Habouzit
2007-11-08 8:41 ` Andreas Ericsson
2007-11-08 15:20 ` Jon Loeliger
2007-11-08 15:47 ` Andreas Ericsson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47332F8E.8080309@op5.se \
--to=ae@op5$(echo .)se \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=jdl@freescale$(echo .)com \
--cc=madcoder@debian$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox