Subject: Re: [PATCH 04/40] Windows: Use the Windows style PATH separator ';'.

From: Paolo Bonzini <[email-masked]>
Date: Fri, 29 Feb 2008 08:57:34 +0100

Johannes Sixt wrote:
> On Thursday 28 February 2008 10:25, Paolo Bonzini wrote:
>>> +#ifdef __MINGW32__
>>> +		strbuf_addch(out, ';');
>>> +#else
>>>  		strbuf_addch(out, ':');
>>> +#endif
>> Why not adding a PATH_SEPARATOR #define?
> 
> Because IMO it is obfuscating:
> 
> 1. When you read through the code and see PATH_SEPARATOR, you still have
> to go look how it's defined. Why? Because you always will ask: Is this 
> about ':' vs. ';' or '/' vs. '\\'?

One is a DIR_SEPARATOR, the other is a PATH_SEPARATOR.  It's a matter of 
conventions.

Paolo