From: Jake Goulding <goulding@vivisimo•com>
To: Jeff King <peff@peff•net>
Cc: Junio C Hamano <gitster@pobox•com>, git@vger•kernel.org
Subject: Re: [REQ] Better error reporting when git rebase cannot rebase
Date: Thu, 03 Apr 2008 09:38:35 -0400 [thread overview]
Message-ID: <47F4DDDB.60706@vivisimo.com> (raw)
In-Reply-To: <20080403095722.GA6673@coredump.intra.peff.net>
Jeff King wrote:
>
> Unfortunately I am not sure of the best way to fix this message. It
> happens at a very low level in read-cache.c, and so it shows up in
> several different places. I am not even sure of all the places you can
> see it, so coming up with different text that makes more sense is
> non-trivial.
>
I was afraid that something like that might be the case. Would it be
worth putting in a second request to make that message more specific?
> But this is, I think, a slightly separate issue, which is that rebase
> just bails without saying why. And that's easy to fix. How about this?
>
> [.snip.]
That seems good to me. I think the important thing is to make sure that
the user is aware that what they wanted to do did not happen.
prev parent reply other threads:[~2008-04-03 13:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-02 15:44 [REQ] Better error reporting when git rebase cannot rebase Jake Goulding
2008-04-03 9:57 ` Jeff King
2008-04-03 13:38 ` Jake Goulding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47F4DDDB.60706@vivisimo.com \
--to=goulding@vivisimo$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=peff@peff$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox