From: "Ferry Huberts (Pelagic)" <ferry.huberts@pelagic•nl>
To: "Shawn O. Pearce" <spearce@spearce•org>
Cc: git@vger•kernel.org
Subject: Re: [EGIT] [PATCH] Make sure that the commit message has Unix format line
Date: Wed, 11 Feb 2009 19:14:00 +0100 [thread overview]
Message-ID: <49931568.6000709@pelagic.nl> (raw)
In-Reply-To: <20090211161346.GD30949@spearce.org>
Shawn O. Pearce wrote:
> "Ferry Huberts (Pelagic)" <ferry.huberts@pelagic•nl> wrote:
>
>> From 2ad66e099fb35ad9a0d97e553843434b68ec82c9 Mon Sep 17 00:00:00 2001 From: Ferry Huberts <ferry.huberts@pelagic•nl>
>> Date: Wed, 11 Feb 2009 08:29:36 +0100
>> Subject: [PATCH] Make sure that the commit message has Unix format line delimiters
>>
>> Signed-off-by: Ferry Huberts <ferry.huberts@pelagic•nl>
>>
>
> Doesn't this change that I committed yesterday also fix this?
>
> commit 72cb3bd763f17a7d9894a8443e05965ff5e77157
> Author: Shawn O. Pearce <spearce@spearce•org>
> Date: Tue Feb 10 09:13:06 2009 -0800
>
> Append Signed-off-by text in the commit message editor
>
> The user can see and edit the Signed-off-by line in the commit
> dialog before committing. Toggling the existing checkbox now
> updates the message to add or remove the user's Signed-off-by
> line, displaying the final message.
>
> Updating the committer name and/or email also updates the
> Signed-off-by line if it is present.
>
> For new lines in the commit dialog, use Text.DELIMITER for
> platform neutrality.
>
> Signed-off-by: Yann Simon <yann.simon.fr@gmail•com>
> Signed-off-by: Shawn O. Pearce <spearce@spearce•org>
>
> Speaking of which, #@!*#@@!*@!!@@!#*, I amended the commit with
> something yesterday and it whacked Yann Simon off as the author
> of that patch and switch it to me.
>
> Crap.
>
>
>> .../egit/ui/internal/actions/CommitAction.java | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/actions/CommitAction.java
>> b/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/actions/CommitAction.java index 5996596..a14011a 100644 ---
>> a/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/actions/CommitAction.java +++
>> b/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/actions/CommitAction.java @@ -128,7 +128,7 @@ public void
>> run(IAction act) {
>> if (commitDialog.open() != IDialogConstants.OK_ID)
>> return;
>>
>> - String commitMessage = commitDialog.getCommitMessage();
>> + String commitMessage = commitDialog.getCommitMessage().replaceAll("\n\r|\r\n", "\n");
>> amending = commitDialog.isAmending();
>> try {
>> performCommit(commitDialog, commitMessage);
>>
>
>
I'm sorry about that. Appearently I was working with an out of date
repository and plugin.
I also agree that fixing it in the getter is a better idea.
This was my first patch for egit, looking forward to more. I'll try to
double check better though :-)
prev parent reply other threads:[~2009-02-11 18:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-11 7:45 [EGIT] [PATCH] Make sure that the commit message has Unix format line Ferry Huberts (Pelagic)
2009-02-11 16:13 ` Shawn O. Pearce
2009-02-11 17:53 ` Robin Rosenberg
2009-02-11 18:14 ` Ferry Huberts (Pelagic) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49931568.6000709@pelagic.nl \
--to=ferry.huberts@pelagic$(echo .)nl \
--cc=git@vger$(echo .)kernel.org \
--cc=spearce@spearce$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox