public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed
From: Ted Pavlic <ted@tedpavlic•com>
To: Junio C Hamano <gitster@pobox•com>
Cc: spearce <spearce@spearce•org>, git <git@vger•kernel.org>
Subject: Re: [PATCH 2/4] completion: Use consistent if [...] convention. No test.
Date: Wed, 11 Feb 2009 13:43:11 -0500	[thread overview]
Message-ID: <49931C3F.4000903@tedpavlic.com> (raw)
In-Reply-To: <7v63jgg7st.fsf@gitster.siamese.dyndns.org>

> What's with this funny indentation?

In Vim, I have "exapndtabs" set by default. I manually turned it off, 
but during testing, I must have closed Vim and re-opened and forgot to 
turn it back off.

Some time ago, I suggested adding a vim modeline to the file to handle 
turning expandtabs off for everyone who edits it with vim. That change 
got denied.

If you'd like, I can clean up the whitespace and resubmit with Shawn's Acks.

--Ted

-- 
Ted Pavlic <ted@tedpavlic•com>

   Please visit my ALS association page:
         http://web.alsa.org/goto/tedpavlic
   My family appreciates your support in the fight to defeat ALS.

  reply	other threads:[~2009-02-11 18:44 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-11 18:03 [PATCH 0/4] completion: Fixes and better non-work-tree support Ted Pavlic
2009-02-11 18:03 ` [PATCH 1/4] completion: For consistency, changed "git rev-parse" to __gitdir calls Ted Pavlic
2009-02-11 18:03   ` [PATCH 2/4] completion: Use consistent if [...] convention. No test Ted Pavlic
2009-02-11 18:03     ` [PATCH 3/4] completion: Better __git_ps1 support when not in working directory Ted Pavlic
2009-02-11 18:03       ` [PATCH 4/4] completion: More fixes to prevent unbound variable errors Ted Pavlic
2009-02-11 18:09         ` Shawn O. Pearce
2009-02-11 18:09       ` [PATCH 3/4] completion: Better __git_ps1 support when not in working directory Shawn O. Pearce
2009-02-11 18:07     ` [PATCH 2/4] completion: Use consistent if [...] convention. No test Shawn O. Pearce
2009-02-11 18:26       ` Junio C Hamano
2009-02-11 18:35         ` Shawn O. Pearce
2009-02-11 18:14     ` Junio C Hamano
2009-02-11 18:43       ` Ted Pavlic [this message]
2009-02-11 22:25         ` Jeff King
2009-02-11 18:54       ` [PATCH 0/4] completion fixes: Acks, whitespace, and r="" Ted Pavlic
2009-02-11 18:54         ` [PATCH 1/4] completion: For consistency, changed "git rev-parse" to __gitdir calls Ted Pavlic
2009-02-11 18:54           ` [PATCH 2/4] completion: Use consistent if [...] convention. No test Ted Pavlic
2009-02-11 18:54             ` [PATCH 3/4] completion: Better __git_ps1 support when not in working directory Ted Pavlic
2009-02-11 18:54               ` [PATCH 4/4] completion: More fixes to prevent unbound variable errors Ted Pavlic
2009-02-20 17:01         ` [PATCH 0/4] completion fixes: Acks, whitespace, and r="" Ted Pavlic
2009-02-20 17:08           ` Thomas Rast
2009-02-20 17:18             ` Ted Pavlic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49931C3F.4000903@tedpavlic.com \
    --to=ted@tedpavlic$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=gitster@pobox$(echo .)com \
    --cc=spearce@spearce$(echo .)org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox