From: "Ferry Huberts (Pelagic)" <ferry.huberts@pelagic•nl>
To: Jeff King <peff@peff•net>
Cc: Johannes Schindelin <johannes.schindelin@gmx•de>, git@vger•kernel.org
Subject: Re: autocrlf=input and safecrlf (was Re: CVS import [SOLVED])
Date: Sat, 21 Feb 2009 00:24:11 +0100 [thread overview]
Message-ID: <499F3B9B.3020709@pelagic.nl> (raw)
In-Reply-To: <20090220172918.GB4636@coredump.intra.peff.net>
Jeff King wrote:
> On Fri, Feb 20, 2009 at 05:25:43PM +0100, Ferry Huberts (Pelagic) wrote:
>
>
>> I replied in the thread with something comparable:
>> http://article.gmane.org/gmane.comp.version-control.git/110358
>>
>> My suggestion is make sure that safecrlf is set to false (see the end
>> part of the mail)
>>
>
> Oh, sorry, I missed that bit. You said:
>
>
>> Back to the issue:
>> I think requiring autocrlf = false is too strict. Requiring autocrlf
>> = false should be enough. That combined with a bit of text in the
>> manual page about these settings: autocrlf = false is strongly
>> recommended. Also, safecrlf is required to be set to false.
>>
>
> Assuming there is a typo and you meant to say "Requiring safecrlf =
> false should be enough", then yes, I agree. But if you are recommending
>
yes that was a typo.
> to put that into the "git cvsimport" manpage, I'm not sure that makes
> sense. Setting autocrlf to input and turning on safecrlf breaks much
> more than that; you can't add any file that has a CRLF in it. So such a
> warning should probably go in the config description for those options.
>
>
I meant that I would add a patch that makes sure that a new repository
is created with that option set to 'off' and that an existing repository
would be checked for that option set to 'off'. I suggested to _also_ add
remarks about this in the man page of cvsimport. Johannes already
suggested a patch but that was for the autocrlf option (trivially
converted to the safecrlf option)
> I still think safecrlf could probably be made more useful in this case
> to differentiate between "this will corrupt your data if you do a
> checkout with your current config settings" and "this will corrupt your
> data forever". But I am not a user of either config variable, so maybe
> there is some subtlety I'm missing.
>
> -Peff
>
I'm a user of these options myself. I maintain several large
repositories that contain data that is used both on Unix and Windows
platforms and that have the autocrlf=input and safecrlf=true. This makes
sure that everything is in Unix format.
Your remark about corrupting your data is a bit strong for my taste.
Corruption from one point of view, making sure that everybody handles
the same content from another :-)
Ferry
next prev parent reply other threads:[~2009-02-20 23:26 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-16 9:17 CVS import Ferry Huberts (Pelagic)
2009-02-16 13:20 ` CVS import [SOLVED] Ferry Huberts (Pelagic)
2009-02-16 13:45 ` Johannes Schindelin
2009-02-16 13:53 ` Johannes Schindelin
2009-02-16 17:33 ` Ferry Huberts (Pelagic)
2009-02-16 18:11 ` Johannes Schindelin
2009-02-16 20:32 ` Ferry Huberts (Pelagic)
2009-02-16 20:59 ` Johannes Schindelin
2009-02-17 11:19 ` Ferry Huberts (Pelagic)
2009-02-17 14:18 ` Johannes Schindelin
2009-02-17 15:16 ` Ferry Huberts (Pelagic)
2009-02-20 15:28 ` Jeff King
2009-02-20 16:25 ` Ferry Huberts (Pelagic)
2009-02-20 17:29 ` autocrlf=input and safecrlf (was Re: CVS import [SOLVED]) Jeff King
2009-02-20 23:24 ` Ferry Huberts (Pelagic) [this message]
2009-02-23 0:08 ` Jeff King
2009-02-23 6:50 ` Ferry Huberts (Pelagic)
2009-02-23 6:56 ` Jeff King
2009-02-23 7:09 ` Ferry Huberts (Pelagic)
2009-02-23 7:10 ` Jeff King
2009-02-23 7:29 ` Ferry Huberts (Pelagic)
2009-02-24 6:11 ` Jeff King
2009-02-24 9:25 ` Ferry Huberts (Pelagic)
2009-02-25 6:56 ` Jeff King
2009-02-25 8:03 ` Ferry Huberts (Pelagic)
2009-02-25 9:03 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=499F3B9B.3020709@pelagic.nl \
--to=ferry.huberts@pelagic$(echo .)nl \
--cc=git@vger$(echo .)kernel.org \
--cc=johannes.schindelin@gmx$(echo .)de \
--cc=peff@peff$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox