From: Johannes Sixt <j.sixt@viscovery•net>
To: Johannes Schindelin <Johannes.Schindelin@gmx•de>
Cc: Junio C Hamano <gitster@pobox•com>, git@vger•kernel.org
Subject: Re: [PATCH 05/10] test-lib: Simplify test counting.
Date: Thu, 19 Mar 2009 08:44:33 +0100 [thread overview]
Message-ID: <49C1F7E1.8090808@viscovery.net> (raw)
In-Reply-To: <alpine.DEB.1.00.0903182331330.10279@pacific.mpi-cbg.de>
Johannes Schindelin schrieb:
> Hi,
>
> On Wed, 18 Mar 2009, Johannes Sixt wrote:
>
>> Since the test case counter was incremented very late, there were a few
>> users of the counter had to do their own incrementing. Now we increment it
>> early and simplify these users.
>>
>> Signed-off-by: Johannes Sixt <j6t@kdbg•org>
>> ---
>> t/test-lib.sh | 10 +++-------
>> 1 files changed, 3 insertions(+), 7 deletions(-)
>
> Do you not need to adjust t4013 and t5515, too?
Yes, indeed. That makes sense.
-- Hannes
next prev parent reply other threads:[~2009-03-19 7:46 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-18 21:27 [PATCH 00/11] Test on Windows - prequel Johannes Sixt
2009-03-18 21:27 ` [PATCH 01/10] t9400, t9401: Do not force hard-linked clone Johannes Sixt
2009-03-18 21:27 ` [PATCH 02/10] test suite: Use 'say' to say something instead of 'test_expect_success' Johannes Sixt
2009-03-18 22:07 ` Johannes Schindelin
2009-03-19 7:48 ` Johannes Sixt
2009-03-19 10:29 ` Johannes Schindelin
2009-03-19 11:16 ` Junio C Hamano
2009-03-18 21:27 ` [PATCH 03/10] Call 'say' outside test_expect_success Johannes Sixt
2009-03-18 21:27 ` [PATCH 04/10] test-lib: Replace uses of $(expr ...) by POSIX shell features Johannes Sixt
2009-03-18 22:28 ` Johannes Schindelin
2009-03-19 7:38 ` Johannes Sixt
2009-03-19 10:27 ` Johannes Schindelin
2009-03-18 21:27 ` [PATCH 05/10] test-lib: Simplify test counting Johannes Sixt
2009-03-18 22:32 ` Johannes Schindelin
2009-03-19 7:44 ` Johannes Sixt [this message]
2009-03-18 21:27 ` [PATCH 06/10] test-lib: Introduce test_chmod and use it instead of update-index --chmod Johannes Sixt
2009-03-18 21:27 ` [PATCH 07/10] t7300: fix clean up on Windows Johannes Sixt
2009-03-18 21:27 ` [PATCH 08/10] t2200, t7004: Avoid glob pattern that also matches files Johannes Sixt
2009-03-19 0:47 ` Junio C Hamano
2009-03-19 19:52 ` Johannes Sixt
2009-03-19 20:34 ` Junio C Hamano
2009-03-18 21:27 ` [PATCH 09/10] t5300, t5302, t5303: Do not use /dev/zero Johannes Sixt
2009-03-18 21:27 ` [PATCH 10/10] t5602: Work around path mangling on MSYS Johannes Sixt
2009-03-18 22:47 ` [PATCH 00/11] Test on Windows - prequel Junio C Hamano
2009-03-19 7:28 ` Johannes Sixt
2009-03-19 20:58 ` Johannes Sixt
2009-03-19 23:00 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49C1F7E1.8090808@viscovery.net \
--to=j.sixt@viscovery$(echo .)net \
--cc=Johannes.Schindelin@gmx$(echo .)de \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox