From: "David J. Mellor" <dmellor@whistlingcat•com>
To: Christian Couder <chriscool@tuxfamily•org>
Cc: gitster@pobox•com, git@vger•kernel.org,
Michael J Gruber <git@drmicha•warpmail.net>
Subject: Re: [PATCH] Documentation: Reworded example text in git-bisect.txt.
Date: Sun, 22 Mar 2009 14:39:05 -0700 [thread overview]
Message-ID: <49C6AFF9.6090204@whistlingcat.com> (raw)
In-Reply-To: <200903210528.32392.chriscool@tuxfamily.org>
On 03/20/2009 09:28 PM, Christian Couder wrote:
> Le vendredi 20 mars 2009, David J. Mellor a écrit :
>
> [...]
>
>> @@ -94,14 +95,14 @@ the bisection state).
>> Bisect visualize
>> ~~~~~~~~~~~~~~~~
>>
>> -During the bisection process, you issue the command:
>> +To see the currently remaining suspects in 'gitk', the following command
>> +is issued during the bisection process:
>
> I think it's better to avoid the passive tone, for example like this:
>
> "To see the currently remaining suspects in 'gitk', you issue the following
> command during the bisection process:"
>
>> ------------
>> $ git bisect visualize
>> ------------
>
> [...]
>
>> @@ -173,8 +175,8 @@ using the "'<commit1>'..'<commit2>'" notation. For
>> example: $ git bisect skip v2.5..v2.6
>> ------------
>>
>> -would mean that no commit between `v2.5` excluded and `v2.6` included
>> -can be tested.
>> +The effect of this would be that no commit between `v2.5` excluded and
>> +`v2.6` included could be tested.
>
> I'd prefer something like:
>
> "This tells the bisect process that no commit between `v2.5` excluded and
> `v2.6` included can be tested."
>
> Otherwise it looks good to me.
>
> Thanks,
> Christian.
>
>
I will send a patch correcting this in my next cycle of documentation
patches. I should send them some time later today.
next prev parent reply other threads:[~2009-03-22 21:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-20 3:35 [PATCH] Documentation: Reworded example text in git-bisect.txt David J. Mellor
2009-03-20 8:59 ` Michael J Gruber
2009-03-21 4:28 ` Christian Couder
2009-03-22 21:39 ` David J. Mellor [this message]
2009-03-23 0:23 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49C6AFF9.6090204@whistlingcat.com \
--to=dmellor@whistlingcat$(echo .)com \
--cc=chriscool@tuxfamily$(echo .)org \
--cc=git@drmicha$(echo .)warpmail.net \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox