From: Michael J Gruber <git@drmicha•warpmail.net>
To: Jakub Narebski <jnareb@gmail•com>
Cc: Olaf Hering <olaf@aepfle•de>,
git@vger•kernel.org,
John 'Warthog9' Hawley <warthog9@eaglescrag•net>
Subject: Re: [PATCH] gitweb: escape searchtext and parameters for replay
Date: Wed, 29 Apr 2009 22:07:07 +0200 [thread overview]
Message-ID: <49F8B36B.6040505@drmicha.warpmail.net> (raw)
In-Reply-To: <200904292136.36987.jnareb@gmail.com>
Jakub Narebski venit, vidit, dixit 29.04.2009 21:36:
> On Wed, 29 Apr 2009, Jakub Narebski wrote:
>> On Wed, 29 Apr 2009, Olaf Hering wrote:
>>> Am 29.04.2009 um 14:28 schrieb Jakub Narebski:
>>>> On Wed, 29 April 2009, Michael J Gruber wrote:
>>>>>>
>>>>>> It should be s=torvalds%40linux instead of s=torvalds\@linux
>>>>
>>>> If you by hand edit URL changing '\@' to simply '@', does changed
>>>> gitweb URL works correctly?
>>>
>>> I tried akpm@osdl•org, and @ and . was escaped with a backslash.
>>> Removing both, and using the plain mail address worked.
>>
>> This problem was fixed in 7e431ef (gitweb: Separate search regexp from
>> search text), but this fix is present in git 1.5.2 and later,
>
> I have just checked that current gitweb (1.6.2.rc1.20.g8c5b)
> does not have this bug...
Yes, I should have tested before suggesting a patch blindly. Sorry!
>
>> and kernel.org gitweb is a fork (adding caching mechanism) of
>> 1.4.5-rc0 (according to info in git.kernel.org HTML source), and
>> it does not have this fix.
>>
>> http://git.kernel.org/?p=git/warthog9/gitweb.git;a=summary
>>
>> I have CC-ed J.H. on this.
>
> ... so J.H., or Lea Wiemann, or whoever manages gitweb on kernel.org
> should backport this fix to kernel.org's fork of gitweb sources.
>
next prev parent reply other threads:[~2009-04-29 20:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-29 9:12 Invalid search parameter in webinterface Olaf Hering
2009-04-29 11:44 ` [PATCH] gitweb: escape searchtext and parameters for replay Michael J Gruber
2009-04-29 12:28 ` Jakub Narebski
2009-04-29 12:52 ` Olaf Hering
2009-04-29 13:14 ` Jakub Narebski
2009-04-29 19:36 ` Jakub Narebski
2009-04-29 20:07 ` Michael J Gruber [this message]
2009-04-29 23:11 ` J.H.
2009-04-30 10:17 ` [PATCH (backport for warthog9/gitweb.git)] gitweb: Separate search regexp from search text Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49F8B36B.6040505@drmicha.warpmail.net \
--to=git@drmicha$(echo .)warpmail.net \
--cc=git@vger$(echo .)kernel.org \
--cc=jnareb@gmail$(echo .)com \
--cc=olaf@aepfle$(echo .)de \
--cc=warthog9@eaglescrag$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox