From: Johannes Sixt <j.sixt@viscovery•net>
To: Jeff King <peff@peff•net>
Cc: Don Slutz <Don.Slutz@SierraAtlantic•com>,
Junio C Hamano <gitster@pobox•com>, Hannu Koivisto <azure@iki•fi>,
git@vger•kernel.org
Subject: Re: Tests in Cygwin
Date: Fri, 08 May 2009 08:02:38 +0200 [thread overview]
Message-ID: <4A03CAFE.4060503@viscovery.net> (raw)
In-Reply-To: <20090508020037.GA1264@coredump.intra.peff.net>
Jeff King schrieb:
> On Thu, May 07, 2009 at 11:47:03AM -0400, Don Slutz wrote:
>
>> Here is a change back to using spaces. It also includes a change
>> to test for the code working. Squash on top.
>
> Maybe it is just me, but I think
>
> test_expect_success SYMLINKS,SANITY 'some description' '
> the actual test
> '
>
> is more readable than the space (since it keeps the number of single
> quoted chunks on the line down). Which should be as simple as:
>
>> -# prerequisites can be concatenated with '+'
>> test_have_prereq () {
>> - save_IFS=$IFS
>> - IFS=+
>> - set -- $*
>> - IFS=$save_IFS
>> - for prerequisite
>> + for prerequisite in $(echo $*)
>> do
>> case $satisfied in
>> *" $prerequisite "*)
>
> +for prerequisite in $(echo "$1" | tr , ' ')
So, you dislike the space separator, but you also dislike the IFS games
that save a few new processes? ;) (Think of Windows, where fork is expensive).
-- Hannes
next prev parent reply other threads:[~2009-05-08 6:02 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-17 9:47 Tests in Cygwin Hannu Koivisto
2009-05-06 19:34 ` Don Slutz
2009-05-06 20:42 ` Junio C Hamano
2009-05-07 7:13 ` Johannes Sixt
2009-05-07 15:47 ` Don Slutz
2009-05-07 18:29 ` Don Slutz
2009-05-08 0:02 ` Junio C Hamano
2009-05-08 6:03 ` Johannes Sixt
2009-05-08 2:00 ` Jeff King
2009-05-08 6:02 ` Johannes Sixt [this message]
2009-05-08 6:41 ` Junio C Hamano
2009-05-08 9:28 ` Alex Riesen
2009-05-08 14:19 ` Don Slutz
2009-05-08 14:28 ` Johannes Sixt
2009-05-08 16:45 ` Alex Riesen
2009-05-08 0:00 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A03CAFE.4060503@viscovery.net \
--to=j.sixt@viscovery$(echo .)net \
--cc=Don.Slutz@SierraAtlantic$(echo .)com \
--cc=azure@iki$(echo .)fi \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=peff@peff$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox