From: "René Scharfe" <rene.scharfe@lsrfire•ath.cx>
To: Stephen Boyd <bebarino@gmail•com>
Cc: Git Mailing List <git@vger•kernel.org>,
Pierre Habouzit <madcoder@debian•org>,
Junio C Hamano <gitster@pobox•com>
Subject: Re: [PATCH 5/5] grep: use parseopt
Date: Sun, 17 May 2009 21:45:16 +0200 [thread overview]
Message-ID: <4A10694C.5010109@lsrfire.ath.cx> (raw)
In-Reply-To: <4A0E8AEF.3000704@gmail.com>
Stephen Boyd schrieb:
> René Scharfe wrote:
>> +int context_callback(const struct option *opt, const char *arg, int unset)
>> +{
>
> Shouldn't these callbacks be static?
Oh, yes, they should.
René
next prev parent reply other threads:[~2009-05-17 19:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-07 19:43 [PATCH 0/5] grep parseopt conversion René Scharfe
2009-05-07 19:44 ` [PATCH 1/5] parseopt: add OPT_NEGBIT René Scharfe
2009-05-08 5:01 ` Jeff King
2009-05-07 19:45 ` [PATCH 2/5] parseopt: add OPT_NUMBER_CALLBACK René Scharfe
2009-05-07 19:45 ` [PATCH 3/5] parseopt: add PARSE_OPT_NODASH René Scharfe
2009-05-07 19:46 ` [PATCH 4/5] grep: remove global variable builtin_grep René Scharfe
2009-05-07 19:46 ` [PATCH 5/5] grep: use parseopt René Scharfe
2009-05-16 9:44 ` Stephen Boyd
2009-05-17 19:45 ` René Scharfe [this message]
2009-05-20 22:05 ` [PATCH] grep: make callback functions static René Scharfe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A10694C.5010109@lsrfire.ath.cx \
--to=rene.scharfe@lsrfire$(echo .)ath.cx \
--cc=bebarino@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=madcoder@debian$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox