From: Ferry Huberts <ferry.huberts@pelagic•nl>
To: "Shawn O. Pearce" <spearce@spearce•org>
Cc: Robin Rosenberg <robin.rosenberg@dewire•com>, git@vger•kernel.org
Subject: Re: [JGIT PATCH 2/2] Allow core.packedGitLimit to exceed "2 g"
Date: Sun, 14 Jun 2009 10:49:40 +0200 [thread overview]
Message-ID: <4A34B9A4.7020702@pelagic.nl> (raw)
In-Reply-To: <20090613191943.GS16497@spearce.org>
> If you looked at that, 2,000,000,000 is within the range of an int.
> We select the smallest value. The first argument expression is
> computed as a long, so we shouldn't ever overflow and cause the
> first argument to be negative. If the first argument is larger
> than 2 billion, then it does risk overflow, but the 2nd argument
> is smaller, so it is returned.
>
> The code is fine as is.
>
I stand corrected :-)
next prev parent reply other threads:[~2009-06-14 8:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-12 23:23 [JGIT PATCH 1/2] Add getLong to RepositoryConfig Shawn O. Pearce
2009-06-12 23:23 ` [JGIT PATCH 2/2] Allow core.packedGitLimit to exceed "2 g" Shawn O. Pearce
2009-06-13 7:56 ` Ferry Huberts
2009-06-13 19:19 ` Shawn O. Pearce
2009-06-14 8:49 ` Ferry Huberts [this message]
2009-06-13 7:57 ` [JGIT PATCH 1/2] Add getLong to RepositoryConfig Ferry Huberts
2009-06-13 19:21 ` Shawn O. Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A34B9A4.7020702@pelagic.nl \
--to=ferry.huberts@pelagic$(echo .)nl \
--cc=git@vger$(echo .)kernel.org \
--cc=robin.rosenberg@dewire$(echo .)com \
--cc=spearce@spearce$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox