public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed
From: Mark Levedahl <mlevedahl@gmail•com>
To: Johan Herland <johan@herland•net>
Cc: Junio C Hamano <gitster@pobox•com>,
	Git Mailing List <git@vger•kernel.org>,
	Lars Hjemli <hjemli@gmail•com>
Subject: Re: [PATCH] git submodule foreach: Provide access to submodule name, as '$name'
Date: Mon, 17 Aug 2009 20:54:39 -0400	[thread overview]
Message-ID: <4A89FBCF.1080400@gmail.com> (raw)
In-Reply-To: <200908160310.08459.johan@herland.net>

Johan Herland wrote:
> The argument to 'git submodule foreach' already has access to the variables
> '$path' (the path to the submodule, relative to the superproject) and '$sha1'
> (the submodule commit recorded by the superproject).
>
> This patch adds another variable -- '$name' -- which contains the name of the
> submodule, as recorded in the superproject's .gitmodules file.
>
> Signed-off-by: Johan Herland <johan@herland•net>
> ---
>   
This patch *looks* ok to me, but I'm out of the office for most of 
August so I cannot actually test this code for another couple of weeks.

Mark

      reply	other threads:[~2009-08-18  0:55 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-16  1:10 [PATCH] git submodule foreach: Provide access to submodule name, as '$name' Johan Herland
2009-08-18  0:54 ` Mark Levedahl [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A89FBCF.1080400@gmail.com \
    --to=mlevedahl@gmail$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=gitster@pobox$(echo .)com \
    --cc=hjemli@gmail$(echo .)com \
    --cc=johan@herland$(echo .)net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox